FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test,crypto: update WebCryptoAPI WPT by panva · Pull Request #55029 · nodejs/node · GitHub

/ node Public

test,crypto: update WebCryptoAPI WPT - #55029

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:bump-webcrypto
Sep 22, 2024
Merged

test,crypto: update WebCryptoAPI WPT#55029
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:bump-webcrypto

Conversation

panva commented Sep 20, 2024

Copy link
Copy Markdown
Member

Just git node wpt WebCryptoAPI.

panva added crypto Issues and PRs related to the crypto subsystem. test Issues and PRs related to the tests. webcrypto web-standards Issues and PRs related to Web APIs labels Sep 20, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/web-standards

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Sep 20, 2024

Copy link
Copy Markdown
Collaborator

codecov Bot commented Sep 20, 2024
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.03%. Comparing base (d5c29ba) to head (0816051).
Report is 512 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #55029      +/-   ##
==========================================
- Coverage   88.06%   88.03%   -0.04%     
==========================================
  Files         652      652              
  Lines      183546   183797     +251     
  Branches    35860    35861       +1     
==========================================
+ Hits       161648   161801     +153     
- Misses      15149    15243      +94     
- Partials     6749     6753       +4     

see 50 files with indirect coverage changes

lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 21, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 21, 2024

nodejs-github-bot commented Sep 21, 2024
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

panva added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Sep 21, 2024
panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 21, 2024
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 22, 2024
nodejs-github-bot merged commit 0e187e4 into nodejs:main Sep 22, 2024

Copy link
Copy Markdown
Collaborator

Landed in 0e187e4

targos pushed a commit that referenced this pull request Oct 4, 2024
PR-URL: #55029
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 mentioned this pull request Oct 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. web-standards Issues and PRs related to Web APIs webcrypto

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL