FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

meta: re-enable PR stalebot by avivkeller · Pull Request #55032 · nodejs/node · GitHub

/ node Public

meta: re-enable PR stalebot - #55032

Closed
avivkeller wants to merge 1 commit into
nodejs:mainfrom
avivkeller:patch-508395
Closed

meta: re-enable PR stalebot#55032
avivkeller wants to merge 1 commit into
nodejs:mainfrom
avivkeller:patch-508395

Conversation

avivkeller commented Sep 20, 2024
edited
Loading

Copy link
Copy Markdown
Member

I propose that this stalebot be re-enabled, as there are hundreds(?) of stale PRs that are over a year old that could benefit from being closed.

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Sep 20, 2024
avivkeller added the review wanted PRs that need reviews. label Oct 8, 2024

Copy link
Copy Markdown
Member

I'm concerned that this will cause a lot of activity in our GitHub notification box and lead to important PRs being overlooked.

avivkeller commented Oct 8, 2024
edited
Loading

Copy link
Copy Markdown
Member Author

I'm concerned that this will cause a lot of activity in our GitHub notification box and lead to important PRs being overlooked.

While that was a concern with this in the past, @mhdawson addressed (AFAICT) by having this only apply to PRs older than a year. I'm happy to adjust that date, but I do think that a stalebot (in any form) is a good thing.

If one year is two soon, we can always start at an arbitrary value (say 3 years or something), and gradually lower the threshold to reduce noise.

Copy link
Copy Markdown
Member

Which value do you think this would bring in case of PRs?

I can see the value for issues, as they are normally a source of state-of-art of a project, but pull requests don't seem to influence anything at all.

avivkeller commented Oct 8, 2024
edited
Loading

Copy link
Copy Markdown
Member Author

Which value do you think this would bring in case of PRs?

Implementing a PR stalebot can help prevent accidental "cookie-licking" (https://devblogs.microsoft.com/oldnewthing/20091201-00/?p=15843). By automatically closing outdated and inactive PRs, it creates an opportunity for new or existing contributors to take on the work themselves, rather than waiting for an old, stale PR to be merged.

I can see the value for issues, as they are normally a source of state-of-art of a project, but pull requests don't seem to influence anything at all.

#54672

avivkeller commented Oct 13, 2024
edited
Loading

Copy link
Copy Markdown
Member Author

I can also, along with the above, lower the op count to ~30 (which is like 5-10 prs, if that), which will only close a few PRs for notification management. It can be increased as needed.

avivkeller closed this by deleting the head repository Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

meta Issues and PRs related to the general management of the project. review wanted PRs that need reviews.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL