FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: unlock versions of irrelevant DB deps by targos · Pull Request #55042 · nodejs/node · GitHub

/ node Public

tools: unlock versions of irrelevant DB deps - #55042

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
targos:revert-no-db-deps
Sep 24, 2024
ConversationCommits (1)ChecksFiles changed
Merged

tools: unlock versions of irrelevant DB deps#55042
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
targos:revert-no-db-deps

Conversation

targos commented Sep 21, 2024

Copy link
Copy Markdown
Member

This essentially reverts e0e0b1a.

We don't bundle ESLint anymore, so the change is no longer needed.

tools: unlock versions of irrelevant DB deps
5b71f84 
This essentially reverts e0e0b1a.

We don't bundle ESLint anymore, so the change is no longer needed.
nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Sep 21, 2024
avivkeller added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Sep 22, 2024
aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 24, 2024
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 24, 2024
nodejs-github-bot merged commit 0257102 into nodejs:main Sep 24, 2024

nodejs-github-bot commented Sep 24, 2024

Copy link
Copy Markdown
Collaborator

Landed in 0257102

targos added a commit that referenced this pull request Oct 4, 2024
tools: unlock versions of irrelevant DB deps
3304bf3 
This essentially reverts e0e0b1a.

We don't bundle ESLint anymore, so the change is no longer needed.

PR-URL: #55042
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 mentioned this pull request Oct 9, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
benjamingr benjamingr approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL