test: deflake test-inspector-strip-types - #55058
Merged
nodejs-github-bot merged 1 commit intoSep 24, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Use the `NodeRuntime.waitingForDebugger` event. Refs: nodejs#51560
Copy link
Copy Markdown
Member
Author
---
duration_ms: 15234.513
exitcode: 1
severity: fail
stack: |-
[test] Connecting to a child Node process
[test] Testing /json/list
[err] Debugger listening on ws://127.0.0.1:42023/4731393b-b955-4019-8f07-0182e30cf571
[err] For help, see: https://nodejs.org/en/docs/inspector
[err]
[err] Debugger attached.
[err]
Timed out waiting for matching notification ((notification) => {
if (notification.method !== 'Debugger.scriptParsed') return false;
return notification.params.url === scriptPath;
})
1
...
Before: $ python3 tools/test.py --repeat=1000 test/parallel/test-inspector-strip-types.js
=== release test-inspector-strip-types ===
Path: parallel/test-inspector-strip-types
[test] Connecting to a child Node process
[test] Testing /json/list
[err] Debugger listening on ws://127.0.0.1:49443/ea1dd0d0-5c93-4ca6-9fd1-a73e017800bb
[err] For help, see: https://nodejs.org/en/docs/inspector
[err]
[err] Debugger attached.
[err]
Timed out waiting for matching notification ((notification) => {
if (notification.method !== 'Debugger.scriptParsed') return false;
return notification.params.url === scriptPath;
})
1
Command: out/Release/node /Users/luigi/code/node/test/parallel/test-inspector-strip-types.js
...
[00:53|% 100|+ 993|- 7]: Done
Failed tests:
out/Release/node /Users/luigi/code/node/test/parallel/test-inspector-strip-types.js
out/Release/node /Users/luigi/code/node/test/parallel/test-inspector-strip-types.js
out/Release/node /Users/luigi/code/node/test/parallel/test-inspector-strip-types.js
out/Release/node /Users/luigi/code/node/test/parallel/test-inspector-strip-types.js
out/Release/node /Users/luigi/code/node/test/parallel/test-inspector-strip-types.js
out/Release/node /Users/luigi/code/node/test/parallel/test-inspector-strip-types.js
out/Release/node /Users/luigi/code/node/test/parallel/test-inspector-strip-types.js
After: $ python3 tools/test.py --repeat=1000 test/parallel/test-inspector-strip-types.js [00:45|% 100|+ 1000|- 0]: Done All tests passed. |
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## main #55058 +/- ##
=======================================
Coverage 88.23% 88.23%
=======================================
Files 652 652
Lines 183912 183912
Branches 35865 35868 +3
=======================================
+ Hits 162272 162275 +3
Misses 14915 14915
+ Partials 6725 6722 -3 |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
aduh95
approved these changes
Sep 22, 2024
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
atlowChemi
approved these changes
Sep 22, 2024
legendecas
approved these changes
Sep 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the NodeRuntime.waitingForDebugger event.
Refs: #51560