FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

lib: fix typos by NathanBaulch · Pull Request #55065 · nodejs/node · GitHub

/ node Public

lib: fix typos - #55065

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
NathanBaulch:typos-lib
Sep 25, 2024
ConversationCommits (1)ChecksFiles changed
Merged

lib: fix typos#55065
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
NathanBaulch:typos-lib

Conversation

NathanBaulch commented Sep 22, 2024

Copy link
Copy Markdown
Contributor

Just thought I'd contribute some typo fixes that I stumbled on. Nothing controversial (hopefully).

Use the following command to get a quick summary of the specific corrections made:

git diff HEAD^! --word-diff-regex='\w+' -U0 \
  | grep -E '\[\-.*\-\]\{\+.*\+\}' \
  | sed -r 's/.*\[\-(.*)\-\]\{\+(.*)\+\}.*/\1 \2/' \
  | sort | uniq -c | sort -n

FWIW, the typos are:

  • relm
  • interal
  • proccess
  • chek
  • implemention
  • mached
  • redudant
  • undeterministic
  • connot
  • gloabl
  • overriden
  • polute
  • stirng
  • transferrable

nodejs-github-bot commented Sep 22, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/loaders
  • @nodejs/net
  • @nodejs/test_runner

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Sep 22, 2024
panva reviewed Sep 22, 2024
View reviewed changes

panva left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This LGTM

avivkeller reviewed Sep 22, 2024
View reviewed changes
Comment thread lib/internal/errors.js
E('ERR_STREAM_PREMATURE_CLOSE', 'Premature close', Error);
E('ERR_STREAM_PUSH_AFTER_EOF', 'stream.push() after EOF', Error);
E('ERR_STREAM_UNABLE_TO_PIPE', 'Connot pipe to a closed or destroyed stream', Error);
E('ERR_STREAM_UNABLE_TO_PIPE', 'Cannot pipe to a closed or destroyed stream', Error);

avivkeller Sep 22, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Is this semver-major, as it changes an error code's output?

panva Sep 22, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Changing the message of an error that has a code is not semver-major PRs that contain breaking changes and should be released in the next major version. , see collaborator-guide

codecov Bot commented Sep 22, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.24%. Comparing base (cfe58cf) to head (4dc8db1).
Report is 422 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #55065      +/-   ##
==========================================
+ Coverage   88.23%   88.24%   +0.01%     
==========================================
  Files         652      652              
  Lines      183912   183911       -1     
  Branches    35865    35865              
==========================================
+ Hits       162272   162293      +21     
+ Misses      14915    14902      -13     
+ Partials     6725     6716       -9
Files with missing lines Coverage Δ
lib/internal/crypto/keys.js 95.75% <100.00%> (ø)
lib/internal/crypto/webidl.js 98.29% <100.00%> (ø)
lib/internal/dns/utils.js 99.43% <100.00%> (ø)
lib/internal/errors.js 96.98% <100.00%> (ø)
lib/internal/fs/glob.js 91.76% <100.00%> (ø)
lib/internal/modules/esm/fetch_module.js 43.37% <100.00%> (ø)
lib/internal/modules/esm/loader.js 98.34% <100.00%> (ø)
lib/internal/process/finalization.js 96.00% <100.00%> (ø)
lib/internal/source_map/source_map_cache_map.js 85.21% <100.00%> (ø)
lib/internal/test_runner/mock/mock_timers.js 98.70% <100.00%> (ø)
... and 4 more

... and 25 files with indirect coverage changes

mcollina approved these changes Sep 22, 2024
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 23, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 23, 2024

nodejs-github-bot commented Sep 23, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62681/

mertcanaltin approved these changes Sep 23, 2024
View reviewed changes

mertcanaltin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

avivkeller added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Sep 23, 2024

nodejs-github-bot commented Sep 25, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62757/

aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 25, 2024
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 25, 2024
nodejs-github-bot merged commit 4c04535 into nodejs:main Sep 25, 2024

nodejs-github-bot commented Sep 25, 2024

Copy link
Copy Markdown
Collaborator

Landed in 4c04535

NathanBaulch deleted the typos-lib branch September 25, 2024 20:24
targos pushed a commit that referenced this pull request Oct 4, 2024
lib: fix typos
bf7d7ae 
PR-URL: #55065
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 mentioned this pull request Oct 9, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

panva panva left review comments
avivkeller avivkeller left review comments
mcollina mcollina approved these changes
lpinca lpinca approved these changes
aduh95 aduh95 approved these changes
atlowChemi atlowChemi approved these changes
LiviaMedeiros LiviaMedeiros approved these changes
+1 more reviewer
mertcanaltin mertcanaltin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL