test_runner: support typescript files in default glob - #55081
Merged
nodejs-github-bot merged 1 commit intoSep 29, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
cjihrig
reviewed
Sep 23, 2024
Comment thread
lib/internal/test_runner/utils.js
Outdated
avivkeller
marked this pull request as ready for review
September 23, 2024 21:32
Copy link
Copy Markdown
|
May be worths also to update docs section. Currently is only mentioned there that js files will be processed |
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## main #55081 +/- ##
=======================================
Coverage 88.24% 88.25%
=======================================
Files 652 651 -1
Lines 183880 183859 -21
Branches 35858 35857 -1
=======================================
- Hits 162271 162261 -10
+ Misses 14900 14891 -9
+ Partials 6709 6707 -2
|
Sorry, something went wrong.
rluvaton
reviewed
Sep 24, 2024
Comment thread
test/parallel/test-runner-cli.js
Outdated
cjihrig
reviewed
Sep 24, 2024
cjihrig
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
The code and docs changes LGTM, but see the previous comment on the test.
Sorry, something went wrong.
marco-ippolito
approved these changes
Sep 28, 2024
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
mcollina
approved these changes
Sep 28, 2024
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jasnell
approved these changes
Sep 28, 2024
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
targos
pushed a commit
that referenced
this pull request
Oct 4, 2024
PR-URL: #55081 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 4, 2024
PR-URL: #55081 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Merged
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft. I haven't added tests for this change yet.
Ready for review
Fixes #55078
Fixes nodejs/help#3902