test_runner: fix mocking modules with quote in their URL - #55083
Merged
nodejs-github-bot merged 1 commit intoSep 25, 2024
Merged
test_runner: fix mocking modules with quote in their URL#55083nodejs-github-bot merged 1 commit into
nodejs-github-bot merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
cjihrig
approved these changes
Sep 23, 2024
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
bnb
approved these changes
Sep 23, 2024
Copy link
Copy Markdown
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## main #55083 +/- ##
==========================================
- Coverage 88.26% 88.24% -0.02%
==========================================
Files 652 652
Lines 183898 183898
Branches 35859 35854 -5
==========================================
- Hits 162309 162282 -27
- Misses 14891 14899 +8
- Partials 6698 6717 +19
|
Sorry, something went wrong.
VoltrexKeyva
approved these changes
Sep 24, 2024
atlowChemi
approved these changes
Sep 24, 2024
targos
pushed a commit
that referenced
this pull request
Oct 4, 2024
PR-URL: #55083 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.