src: move more key handling to ncrypto - #55108
Merged
nodejs-github-bot merged 1 commit intoSep 28, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
This comment was marked as outdated.
anonrig
reviewed
Sep 24, 2024
Comment thread
deps/ncrypto/ncrypto.cc
Outdated
jasnell
force-pushed
the
moar-evp-key-to-ncrypto
branch
from
7bdbb3b to
a886db5
Compare
September 24, 2024 21:08
This comment was marked as outdated.
anonrig
approved these changes
Sep 24, 2024
Copy link
Copy Markdown
Codecov ReportAttention: Patch coverage is 80.26316% with 15 lines in your changes missing coverage. Please review.
@@ Coverage Diff @@
## main #55108 +/- ##
==========================================
- Coverage 88.25% 88.25% -0.01%
==========================================
Files 651 651
Lines 183900 183818 -82
Branches 35860 35834 -26
==========================================
- Hits 162296 162222 -74
- Misses 14894 14905 +11
+ Partials 6710 6691 -19
|
Sorry, something went wrong.
jasnell
force-pushed
the
moar-evp-key-to-ncrypto
branch
from
a886db5 to
23802fb
Compare
September 24, 2024 22:43
This comment was marked as outdated.
anonrig
approved these changes
Sep 24, 2024
Comment thread
deps/ncrypto/ncrypto.cc
Outdated
jasnell
force-pushed
the
moar-evp-key-to-ncrypto
branch
from
23802fb to
c23255d
Compare
September 26, 2024 19:49
jasnell
force-pushed
the
moar-evp-key-to-ncrypto
branch
from
c23255d to
4ef5c9e
Compare
September 26, 2024 19:57
This comment was marked as outdated.
This comment was marked as outdated.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
anonrig
approved these changes
Sep 28, 2024
KhafraDev
approved these changes
Sep 28, 2024
targos
pushed a commit
that referenced
this pull request
Oct 4, 2024
PR-URL: #55108 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 4, 2024
PR-URL: #55108 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Merged
npaun
pushed a commit
to npaun/ncrypto
that referenced
this pull request
Sep 18, 2025
PR-URL: nodejs/node#55108 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More incremental moving of evp key handlnig to ncrypto