FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: remove outdated https import reference by geeksilva97 · Pull Request #55111 · nodejs/node · GitHub

/ node Public

doc: remove outdated https import reference - #55111

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
geeksilva97:issue-55091
Sep 28, 2024
ConversationCommits (1)ChecksFiles changed
Merged

doc: remove outdated https import reference#55111
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
geeksilva97:issue-55091

Conversation

geeksilva97 commented Sep 25, 2024 •
edited by aduh95
Loading

Copy link
Copy Markdown
Contributor

Refs: #53822
Fixes: #55091

nodejs-github-bot commented Sep 25, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders

nodejs-github-bot added doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem. labels Sep 25, 2024

avivkeller commented Sep 25, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Can you amend your commit message to start with the subsystem you are changing, in this case doc?

A valid commit would look like:

doc: remove outdated https import reference

geeksilva97 commented Sep 25, 2024

Copy link
Copy Markdown
Contributor Author

Can you amend your commit message to start with the subsystem you are changing, in this case doc?

A valid commit would look like:

doc: remove outdated https import reference

Done

aduh95 added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Sep 25, 2024
geeksilva97 changed the title Remove old references from doc doc: remove outdated https import reference Sep 27, 2024
aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 28, 2024
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 28, 2024
nodejs-github-bot merged commit 6d1cd50 into nodejs:main Sep 28, 2024

nodejs-github-bot commented Sep 28, 2024

Copy link
Copy Markdown
Collaborator

Landed in 6d1cd50

targos pushed a commit that referenced this pull request Oct 4, 2024
doc: remove outdated https import reference
1f7566d 
PR-URL: #55111
Fixes: #55091
Refs: #53822
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Oct 4, 2024
doc: remove outdated https import reference
bb34990 
PR-URL: #55111
Fixes: #55091
Refs: #53822
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 mentioned this pull request Oct 9, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
UlisesGascon UlisesGascon approved these changes
aduh95 aduh95 approved these changes
atlowChemi atlowChemi approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Modules: node:module API > Customization Hooks > Examples > Import from HTTPS

8 participants

Back | FazBrowse Home | New Git URL