buffer: correctly apply prototype to cloned File / Blob - #55138
Merged
nodejs-github-bot merged 1 commit intoSep 28, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
H4ad
approved these changes
Sep 26, 2024
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## main #55138 +/- ##
==========================================
- Coverage 88.24% 88.23% -0.01%
==========================================
Files 651 651
Lines 183905 183907 +2
Branches 35864 35866 +2
==========================================
- Hits 162286 162279 -7
- Misses 14905 14911 +6
- Partials 6714 6717 +3
|
Sorry, something went wrong.
aduh95
approved these changes
Sep 27, 2024
jasnell
approved these changes
Sep 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup #47613
Reference #55067
The prototype of the transferred File / Blob should be equal to it's closest transferable superclass. This PR applies the same change as #55067 did to Streams to Files and Blobs.