FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: remove random horizontal separators in `process.md` by aduh95 · Pull Request #55149 · nodejs/node · GitHub

/ node Public

doc: remove random horizontal separators in process.md - #55149

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:no-hr-process.md
Sep 28, 2024
Merged

doc: remove random horizontal separators in process.md#55149
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:no-hr-process.md

Conversation

aduh95 commented Sep 28, 2024

Copy link
Copy Markdown
Contributor

They don't seem to have any meaning (the sections it separates are not more different than any other pair of two sections) and I don't think we use those anywhere else in our docs, I suspect they were added by mistake.

nodejs-github-bot added doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem. labels Sep 28, 2024

marco-ippolito left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yes added by mistake LGTM

marco-ippolito added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 28, 2024

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @marco-ippolito. Please 👍 to approve.

marco-ippolito added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Sep 28, 2024
aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 28, 2024
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 28, 2024
nodejs-github-bot merged commit 23743f6 into nodejs:main Sep 28, 2024

Copy link
Copy Markdown
Collaborator

Landed in 23743f6

aduh95 deleted the no-hr-process.md branch September 28, 2024 12:26
targos pushed a commit that referenced this pull request Oct 4, 2024
PR-URL: #55149
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
targos pushed a commit that referenced this pull request Oct 4, 2024
PR-URL: #55149
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
aduh95 mentioned this pull request Oct 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. process Issues and PRs related to the process subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL