FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: add resource to internal module stat test by RafaelGSS · Pull Request #55157 · nodejs/node · GitHub

/ node Public

test: add resource to internal module stat test - #55157

Closed
RafaelGSS wants to merge 2 commits into
nodejs:mainfrom
RafaelGSS:add-resource-to-stat-test
Closed

test: add resource to internal module stat test#55157
RafaelGSS wants to merge 2 commits into
nodejs:mainfrom
RafaelGSS:add-resource-to-stat-test

Conversation

Copy link
Copy Markdown
Member

This was missing from #51344

nodejs-github-bot commented Sep 28, 2024
edited by RafaelGSS
Loading

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/security-wg

RafaelGSS added the permission Issues and PRs related to the Permission Model label Sep 28, 2024
nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 28, 2024

codecov Bot commented Sep 28, 2024
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.24%. Comparing base (3ac5b49) to head (ee3f3ac).
Report is 175 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #55157      +/-   ##
==========================================
+ Coverage   88.07%   88.24%   +0.17%     
==========================================
  Files         652      651       -1     
  Lines      183653   183855     +202     
  Branches    35856    35825      -31     
==========================================
+ Hits       161753   162249     +496     
+ Misses      15146    14921     -225     
+ Partials     6754     6685      -69     

see 152 files with indirect coverage changes

RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2024

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

RafaelGSS requested a review from anonrig September 30, 2024 14:32
RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 30, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 30, 2024

Copy link
Copy Markdown
Collaborator

anonrig requested a review from jasnell September 30, 2024 15:12
RafaelGSS added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Oct 2, 2024
RafaelGSS added a commit that referenced this pull request Oct 7, 2024
PR-URL: #55157
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

Copy link
Copy Markdown
Member Author

Landed in 6c92c13

RafaelGSS closed this Oct 7, 2024
aduh95 pushed a commit that referenced this pull request Oct 9, 2024
PR-URL: #55157
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95 mentioned this pull request Oct 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. permission Issues and PRs related to the Permission Model test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL