FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

meta: move one or more collaborators to emeritus by nodejs-github-bot · Pull Request #55167 · nodejs/node · GitHub

/ node Public

meta: move one or more collaborators to emeritus - #55167

Closed
nodejs-github-bot wants to merge 1 commit into
mainfrom
actions/inactive-collaborators
ConversationCommits (1)ChecksFiles changed
Closed

meta: move one or more collaborators to emeritus#55167
nodejs-github-bot wants to merge 1 commit into
mainfrom
actions/inactive-collaborators

Conversation

nodejs-github-bot commented Sep 30, 2024

Copy link
Copy Markdown
Collaborator

This PR was generated by the find-inactive-collaborators.yml workflow.

@nodejs/tsc Please follow up with the offboarding tasks.

nodejs-github-bot added meta Issues and PRs related to the general management of the project. doc Issues and PRs related to the documentations. labels Sep 30, 2024

marco-ippolito commented Sep 30, 2024

Copy link
Copy Markdown
Member

I think @abmusse was recently onboarded right?

jakecastelli requested changes Sep 30, 2024
View reviewed changes

jakecastelli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

FYI: The email @abmusse used to commit in the repo it is not the same email listed on the README.

the email used to commit: 33973272+abmusse@users.noreply.github.com

the email bot checked against: abdirahim.musse@ibm.com

I think this might be the reason

aduh95 commented Sep 30, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

They would need to add an entry in the .mailmap so git log -1 --format=pretty:%aE b8493a5789c178246fb214f9ca04f9b9840a443a reports the same email address that's listed on the README.

abmusse commented Sep 30, 2024

Copy link
Copy Markdown
Contributor

Hello everyone, I'll work on getting my email added to the mailmap.

abmusse commented Sep 30, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

@aduh95

I would need to do something similar to this entry right?

node/.mailmap

Line 9 in bbf08c6

Akhil Marsonya <akhil.marsonya27@gmail.com> <16393876+marsonya@users.noreply.github.com>

abmusse mentioned this pull request Sep 30, 2024
Merged

richardlau commented Sep 30, 2024

Copy link
Copy Markdown
Member

I would need to do something similar to this entry right?

node/.mailmap

Line 9 in bbf08c6

Akhil Marsonya <akhil.marsonya27@gmail.com> <16393876+marsonya@users.noreply.github.com>

FYI .mailmap is defined by git: https://git-scm.com/docs/gitmailmap
(I've already let @abmusse know, but it's useful for anyone else reading this later)

avivkeller closed this Sep 30, 2024

avivkeller commented Sep 30, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

This PR was created from a nonexistent mailmap entry. See #55182

@abmusse isn't inactive so I've closed this PR.

aduh95 deleted the actions/inactive-collaborators branch September 30, 2024 22:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jakecastelli jakecastelli requested changes

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL