FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Enable linting for benchmarks by Trott · Pull Request #5517 · nodejs/node · GitHub

/ node Public

Enable linting for benchmarks - #5517

Closed
Trott wants to merge 2 commits into
nodejs:masterfrom
Trott:simplify
ConversationCommits (2)ChecksFiles changed
Closed

Enable linting for benchmarks#5517
Trott wants to merge 2 commits into
nodejs:masterfrom
Trott:simplify

Conversation

Trott commented Mar 2, 2016

Copy link
Copy Markdown
Member

Refactor benchmarks to conform with existing lint rules. (In the process, a few broken benchmarks were fixed, e.g. the one for domains.) Enable linting for benchmarks.

/cc @nodejs/benchmarking @mscdex

Trott added benchmark Issues and PRs related to the benchmark subsystem. tools Issues and PRs related to the tools directory. lts-watch-v4.x labels Mar 2, 2016

Trott commented Mar 2, 2016

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/1801/

mscdex reviewed Mar 2, 2016
View reviewed changes
Comment thread benchmark/buffers/buffer-indexof.js Outdated

mscdex Mar 2, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Wouldn't having the last parenthesis on the next line be more consistent (and IMHO better looking) with the changes made in benchmark/compare.js?

Trott Mar 2, 2016

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Agreed. Will change and push.

Trott commented Mar 2, 2016

Copy link
Copy Markdown
Member Author

Fixup commit pushed based on @mscdex feedback. PTAL.

mscdex commented Mar 2, 2016

Copy link
Copy Markdown
Contributor

LGTM if CI is still ok with it

Trott commented Mar 2, 2016

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/1802/

targos commented Mar 2, 2016

Copy link
Copy Markdown
Member

LGTM

2 similar comments

evanlucas commented Mar 2, 2016

Copy link
Copy Markdown
Contributor

LGTM

jasnell commented Mar 2, 2016

Copy link
Copy Markdown
Member

LGTM

jasnell commented Mar 2, 2016

Copy link
Copy Markdown
Member

Looks like the PR may need a quick rebase and update before landing.

Trott commented Mar 2, 2016

Copy link
Copy Markdown
Member Author

@jasnell Rebased!

jasnell pushed a commit that referenced this pull request Mar 3, 2016
benchmark: fix lint errors
1bedeeb 
PR-URL: #5517
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this pull request Mar 3, 2016
tools: enable linting for benchmarks
6d22003 
PR-URL: #5517
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell commented Mar 3, 2016

Copy link
Copy Markdown
Member

Landed in 1bedeeb and 6d22003

jasnell closed this Mar 3, 2016
Fishrock123 mentioned this pull request Mar 7, 2016
Merged
Fishrock123 pushed a commit that referenced this pull request Mar 8, 2016
benchmark: fix lint errors
65f4ecc 
PR-URL: #5517
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Fishrock123 pushed a commit that referenced this pull request Mar 8, 2016
tools: enable linting for benchmarks
2682b1c 
PR-URL: #5517
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Fishrock123 pushed a commit that referenced this pull request Mar 8, 2016
benchmark: fix lint errors
b955d02 
PR-URL: #5517
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Fishrock123 pushed a commit that referenced this pull request Mar 8, 2016
tools: enable linting for benchmarks
9a3e87e 
PR-URL: #5517
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins commented Mar 17, 2016

Copy link
Copy Markdown
Contributor

@Trott this one too for benchmarking backport

Trott mentioned this pull request Mar 18, 2016
Closed
Trott deleted the simplify branch January 13, 2022 22:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

benchmark Issues and PRs related to the benchmark subsystem. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL