FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src,test: drop SlowBuffer by RafaelGSS · Pull Request #55176 · nodejs/node · GitHub

/ node Public

src,test: drop SlowBuffer - #55176

Closed
RafaelGSS wants to merge 1 commit into
nodejs:mainfrom
RafaelGSS:drop-slow-buffer
ConversationCommits (1)ChecksFiles changed
Closed

src,test: drop SlowBuffer#55176
RafaelGSS wants to merge 1 commit into
nodejs:mainfrom
RafaelGSS:drop-slow-buffer

Conversation

RafaelGSS commented Sep 30, 2024

Copy link
Copy Markdown
Member

Depends on #55175.

It should land only on Node.js 24*.

To avoid inconsistencies, I'm adding a blocked label so we land on main only when 23 goes out.

RafaelGSS added blocked PRs that are blocked by other issues or PRs. dont-land-on-v18.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels Sep 30, 2024

nodejs-github-bot commented Sep 30, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/performance

nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Sep 30, 2024

avivkeller commented Oct 1, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

The removal of a feature must be semver major. Additionally, with this being semver major, it doesn't need all the "don't-land" labels, as it can't land on LTS lines anyway, right?

avivkeller added semver-major PRs that contain breaking changes and should be released in the next major version. and removed dont-land-on-v18.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels Oct 1, 2024
mcollina approved these changes Oct 1, 2024
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

RafaelGSS commented Oct 1, 2024

Copy link
Copy Markdown
Member Author

The removal of a feature must be semver major. Additionally, with this being semver major, it doesn't need all the "don't-land" labels, as it can't land on LTS lines anyway, right?

Incorrect. It will be next-semver-major, it should not land on v23.x.

avivkeller removed blocked PRs that are blocked by other issues or PRs. dont-land-on-v23.x labels Oct 16, 2024

avivkeller commented Oct 16, 2024

Copy link
Copy Markdown
Member

The blocking PR has landed, and this PR can no longer land on v23 due to the semver-major label. I've updated the labels accordingly.

RafaelGSS commented Oct 21, 2024

Copy link
Copy Markdown
Member Author

I'm open a fresh PR once v24 goes out :)

RafaelGSS closed this Oct 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
anonrig anonrig approved these changes

Assignees

No one assigned

Labels

buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL