tools: enforce errors to not be documented in legacy section - #55218
Merged
nodejs-github-bot merged 3 commits intoOct 8, 2024
Merged
tools: enforce errors to not be documented in legacy section#55218nodejs-github-bot merged 3 commits into
nodejs-github-bot merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## main #55218 +/- ##
==========================================
- Coverage 88.41% 88.40% -0.02%
==========================================
Files 652 652
Lines 186572 186572
Branches 36045 36041 -4
==========================================
- Hits 164957 164938 -19
- Misses 14899 14905 +6
- Partials 6716 6729 +13 |
Sorry, something went wrong.
aduh95
reviewed
Oct 2, 2024
Comment thread
doc/api/errors.md
Outdated
aduh95
reviewed
Oct 2, 2024
Comment thread
tools/eslint-rules/documented-errors.js
Outdated
Copy link
Copy Markdown
Member
Author
|
ack! That's not what I meant to do. --force will be the end of me... I'll reopen in a moment. |
Sorry, something went wrong.
aduh95
reviewed
Oct 2, 2024
Comment thread
doc/api/errors.md
Outdated
Copy link
Copy Markdown
Contributor
|
Can you please rebase? |
Sorry, something went wrong.
aduh95
reviewed
Oct 2, 2024
Comment thread
tools/eslint-rules/documented-errors.js
Outdated
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
approved these changes
Oct 2, 2024
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/55218 ✔ Done loading data for nodejs/node/pull/55218 ----------------------------------- PR info ------------------------------------ Title tools: enforce errors to not be documented in legacy section (#55218) Author Aviv Keller <redyetidev@gmail.com> (@RedYetiDev) Branch RedYetiDev:patch-531581 -> nodejs:main Labels doc, tools, errors, author ready, commit-queue-squash Commits 3 - tools: enforce errors to not be documented in legacy section - fixup! tools: enforce errors to not be documented in legacy section - Update documented-errors.js Committers 2 - RedYetiDev <38299977+RedYetiDev@users.noreply.github.com> - GitHub <noreply@github.com> PR-URL: https://github.com/nodejs/node/pull/55218 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/55218 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 01 Oct 2024 16:58:13 GMT ✔ Approvals: 1 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/55218#pullrequestreview-2343976038 ✘ This PR needs to wait 7 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-10-02T20:14:07Z: https://ci.nodejs.org/job/node-test-pull-request/62900/ - Querying data for job/node-test-pull-request/62900/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/11233008727 |
Sorry, something went wrong.
aduh95
pushed a commit
that referenced
this pull request
Oct 9, 2024
PR-URL: #55218 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the lint rule to enforce that errors are in the right category. That is, errors that exist are not placed under the deprecated cateogory.