FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

v8: out of bounds copy by ronag · Pull Request #55261 · nodejs/node · GitHub

/ node Public

v8: out of bounds copy - #55261

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
nxtedition:54573
Oct 7, 2024
ConversationCommits (1)ChecksFiles changed
Merged

v8: out of bounds copy#55261
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
nxtedition:54573

Conversation

ronag commented Oct 4, 2024

Copy link
Copy Markdown
Member

Fixes: #54573

ronag self-assigned this Oct 4, 2024
nodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 4, 2024

ronag commented Oct 4, 2024

Copy link
Copy Markdown
Member Author

@nodejs/buffer

avivkeller added buffer Issues and PRs related to the buffer subsystem. v8 module Issues and PRs related to the "v8" subsystem. labels Oct 4, 2024
ramidzkh reviewed Oct 4, 2024
View reviewed changes
Comment thread lib/v8.js Outdated

codecov Bot commented Oct 4, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.89%. Comparing base (d2ad9b4) to head (dd44a41).
Report is 288 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #55261      +/-   ##
==========================================
- Coverage   88.41%   87.89%   -0.53%     
==========================================
  Files         652      652              
  Lines      186594   186611      +17     
  Branches    36054    35757     -297     
==========================================
- Hits       164980   164014     -966     
- Misses      14883    15821     +938     
- Partials     6731     6776      +45
Files with missing lines Coverage Δ
lib/v8.js 98.64% <100.00%> (-0.69%) ⬇️

... and 92 files with indirect coverage changes

ramidzkh reviewed Oct 4, 2024
View reviewed changes
Comment thread lib/v8.js Outdated
avivkeller reviewed Oct 4, 2024
View reviewed changes

avivkeller left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can mark the original author as a co-author, if needed?

nit: "v8" might be a better subsystem than "buffer"

Comment thread test/parallel/test-v8-deserialize-buffer.js Outdated
ronag force-pushed the 54573 branch 2 times, most recently from c716656 to 7332ad1 Compare October 4, 2024 11:13
ronag changed the title fix: out of bounds copy v8: out of bounds copy Oct 4, 2024
ramidzkh reviewed Oct 4, 2024
View reviewed changes
Comment thread test/parallel/test-v8-deserialize-buffer.js Outdated
Comment thread lib/v8.js Outdated
arneg mentioned this pull request Oct 4, 2024
Closed
ronag force-pushed the 54573 branch 2 times, most recently from 0d57b24 to 5c04ef2 Compare October 5, 2024 12:17
ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 5, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 5, 2024

nodejs-github-bot commented Oct 5, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62927/

v8: out of bounds copy
dd44a41 
Fixes: nodejs#54573

Co-authored-by: ronag <ronagy@icloud.com>
Co-authored-by: ramidzkh <ramidzkh@gmail.com>
ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 5, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 5, 2024

nodejs-github-bot commented Oct 5, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62929/

nodejs-github-bot commented Oct 6, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62935/

ronag requested review from ShogunPanda and mcollina October 6, 2024 01:22
avivkeller added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Oct 7, 2024
joyeecheung approved these changes Oct 7, 2024
View reviewed changes

joyeecheung left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM though I think this could do better with the commit description (why the regression happened).

ronag added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 7, 2024
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 7, 2024
nodejs-github-bot merged commit deb5eff into nodejs:main Oct 7, 2024

nodejs-github-bot commented Oct 7, 2024

Copy link
Copy Markdown
Collaborator

Landed in deb5eff

aduh95 pushed a commit that referenced this pull request Oct 9, 2024
v8: out of bounds copy
ea7aaf3 
Fixes: #54573

Co-authored-by: ronag <ronagy@icloud.com>
Co-authored-by: ramidzkh <ramidzkh@gmail.com>
PR-URL: #55261
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
aduh95 mentioned this pull request Oct 9, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

avivkeller avivkeller left review comments
anonrig anonrig approved these changes
joyeecheung joyeecheung approved these changes
mcollina Awaiting requested review from mcollina
ShogunPanda Awaiting requested review from ShogunPanda
+1 more reviewer
ramidzkh ramidzkh left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. buffer Issues and PRs related to the buffer subsystem. needs-ci PRs that need a full CI run. v8 module Issues and PRs related to the "v8" subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Parcel 2.12.0 malloc(): corrupted top size in Node 22.7.0

7 participants

Back | FazBrowse Home | New Git URL