FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

lib: remove `Symbol[Async]Dispose` polyfills by targos · Pull Request #55276 · nodejs/node · GitHub

/ node Public

lib: remove Symbol[Async]Dispose polyfills - #55276

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
targos:rm-symbol-dispose-polyfill
Oct 7, 2024
ConversationCommits (1)ChecksFiles changed
Merged

lib: remove Symbol[Async]Dispose polyfills#55276
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
targos:rm-symbol-dispose-polyfill

Conversation

targos commented Oct 5, 2024

Copy link
Copy Markdown
Member

No description provided.

targos added dont-land-on-v18.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels Oct 5, 2024

nodejs-github-bot commented Oct 5, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/http
  • @nodejs/http2
  • @nodejs/net
  • @nodejs/streams
  • @nodejs/test_runner

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Oct 5, 2024
targos mentioned this pull request Oct 5, 2024
Closed

codecov Bot commented Oct 5, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.40%. Comparing base (bbdfeeb) to head (9ccc762).
Report is 8 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #55276      +/-   ##
==========================================
- Coverage   88.41%   88.40%   -0.02%     
==========================================
  Files         652      652              
  Lines      186612   186573      -39     
  Branches    36062    36058       -4     
==========================================
- Hits       165001   164943      -58     
- Misses      14885    14894       +9     
- Partials     6726     6736      +10
Files with missing lines Coverage Δ
lib/_http_server.js 96.74% <100.00%> (+0.08%) ⬆️
lib/child_process.js 97.74% <100.00%> (ø)
lib/dgram.js 97.32% <100.00%> (+<0.01%) ⬆️
lib/events.js 99.83% <100.00%> (+<0.01%) ⬆️
lib/https.js 99.30% <100.00%> (ø)
lib/inspector.js 96.27% <100.00%> (-0.06%) ⬇️
lib/internal/child_process.js 95.07% <100.00%> (+<0.01%) ⬆️
lib/internal/events/abort_listener.js 100.00% <100.00%> (ø)
lib/internal/fs/promises.js 98.24% <100.00%> (ø)
lib/internal/http2/core.js 95.53% <100.00%> (ø)
... and 15 more

... and 36 files with indirect coverage changes

targos added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 5, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 5, 2024

nodejs-github-bot commented Oct 5, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62926/

mcollina approved these changes Oct 5, 2024
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Lgtm

avivkeller added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Oct 5, 2024

nodejs-github-bot commented Oct 5, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62930/

mertcanaltin approved these changes Oct 5, 2024
View reviewed changes

mertcanaltin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

nodejs-github-bot commented Oct 6, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62942/

atlowChemi added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 7, 2024
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 7, 2024
nodejs-github-bot merged commit d5eb9a3 into nodejs:main Oct 7, 2024

nodejs-github-bot commented Oct 7, 2024

Copy link
Copy Markdown
Collaborator

Landed in d5eb9a3

This was referenced Oct 8, 2024
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
Qard Qard approved these changes
lpinca lpinca approved these changes
anonrig anonrig approved these changes
MoLow MoLow approved these changes
atlowChemi atlowChemi approved these changes
+1 more reviewer
mertcanaltin mertcanaltin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

Back | FazBrowse Home | New Git URL