doc: reserve 132 for Electron 34 - #55306
Merged
nodejs-github-bot merged 1 commit intoOct 9, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This PR reserves NMV 132 for Electron 34
richardlau
approved these changes
Oct 7, 2024
mlaurencin
added a commit
to electron/electron
that referenced
this pull request
Oct 7, 2024
Node PR: nodejs/node#55306 Do not merge before attached Node PR is merged. This PR updates our NMV to 132 for Electron 34 Please merge this PR before branching 34-x-y
5 tasks
jakecastelli
approved these changes
Oct 7, 2024
UlisesGascon
approved these changes
Oct 8, 2024
mhdawson
approved these changes
Oct 8, 2024
mhdawson
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
VerteDinde
pushed a commit
to electron/electron
that referenced
this pull request
Oct 9, 2024
Node PR: nodejs/node#55306 Do not merge before attached Node PR is merged. This PR updates our NMV to 132 for Electron 34 Please merge this PR before branching 34-x-y
yangannyx
pushed a commit
to yangannyx/electron
that referenced
this pull request
Oct 21, 2024
Node PR: nodejs/node#55306 Do not merge before attached Node PR is merged. This PR updates our NMV to 132 for Electron 34 Please merge this PR before branching 34-x-y
yangannyx
pushed a commit
to yangannyx/electron
that referenced
this pull request
Oct 21, 2024
Node PR: nodejs/node#55306 Do not merge before attached Node PR is merged. This PR updates our NMV to 132 for Electron 34 Please merge this PR before branching 34-x-y
yangannyx
pushed a commit
to yangannyx/electron
that referenced
this pull request
Oct 21, 2024
Node PR: nodejs/node#55306 Do not merge before attached Node PR is merged. This PR updates our NMV to 132 for Electron 34 Please merge this PR before branching 34-x-y
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reserves NMV 132 for Electron 34