FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fs: fix linter issue by aduh95 · Pull Request #55353 · nodejs/node · GitHub

/ node Public

fs: fix linter issue - #55353

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
aduh95:lint-fs
Oct 10, 2024
ConversationCommits (2)ChecksFiles changed
Merged

fs: fix linter issue#55353
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
aduh95:lint-fs

Conversation

aduh95 commented Oct 10, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Linter is failing on main, it seems #54160 landed with an outdated CI.

nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Oct 10, 2024
aduh95 added fast-track PRs that do not need to wait for 48 hours to land. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 10, 2024

github-actions Bot commented Oct 10, 2024

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 10, 2024

nodejs-github-bot commented Oct 10, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63032/

avivkeller added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Oct 10, 2024
atlowChemi reviewed Oct 10, 2024
View reviewed changes
Comment thread test/sequential/test-fs-path-dir.js Outdated
Update test/sequential/test-fs-path-dir.js
d5152b3 
Co-authored-by: Chemi Atlow <chemi@atlow.co.il>
atlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 10, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 10, 2024

nodejs-github-bot commented Oct 10, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63033/

codecov Bot commented Oct 10, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.40%. Comparing base (7178588) to head (d5152b3).
Report is 337 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #55353      +/-   ##
==========================================
+ Coverage   88.38%   88.40%   +0.01%     
==========================================
  Files         652      652              
  Lines      186740   186777      +37     
  Branches    36036    36041       +5     
==========================================
+ Hits       165058   165121      +63     
+ Misses      14934    14922      -12     
+ Partials     6748     6734      -14
Files with missing lines Coverage Δ
lib/internal/fs/utils.js 99.70% <100.00%> (+0.01%) ⬆️

... and 23 files with indirect coverage changes

nodejs-github-bot commented Oct 10, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63036/

richardlau added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Oct 10, 2024
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 10, 2024
nodejs-github-bot merged commit 9f9069d into nodejs:main Oct 10, 2024

nodejs-github-bot commented Oct 10, 2024

Copy link
Copy Markdown
Collaborator

Landed in 9f9069d

aduh95 deleted the lint-fs branch October 11, 2024 05:51
aduh95 mentioned this pull request Oct 14, 2024
Merged

ruyadorno commented Nov 27, 2024

Copy link
Copy Markdown
Member

This commit does not land cleanly on v22.x-staging and will need manual backport in case we want it in v22.x.

ruyadorno added the backport-requested-v22.x PRs awaiting manual backport to the v22.x-staging branch. label Nov 27, 2024
aduh95 added dont-land-on-v18.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. and removed backport-requested-v22.x PRs awaiting manual backport to the v22.x-staging branch. labels Nov 27, 2024
ruyadorno mentioned this pull request Nov 27, 2024
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
anonrig anonrig approved these changes
richardlau richardlau approved these changes
atlowChemi atlowChemi approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. fast-track PRs that do not need to wait for 48 hours to land. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL