test: check memoryUsage properties - #5546
Closed
geek wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
LGTM |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
geek
added a commit
that referenced
this pull request
Mar 3, 2016
The properties on memoryUsage were not checked before, this commit checks them. PR-URL: #5546 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
Fishrock123
pushed a commit
that referenced
this pull request
Mar 8, 2016
The properties on memoryUsage were not checked before, this commit checks them. PR-URL: #5546 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Fishrock123
pushed a commit
that referenced
this pull request
Mar 8, 2016
The properties on memoryUsage were not checked before, this commit checks them. PR-URL: #5546 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 17, 2016
… not checked before, this commit checks them. PR-URL: #5546 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Copy link
Copy Markdown
Contributor
|
This commit is causing a false positive with branch-diff due to the title being too long. I'm adding dont-land so we can have it ignored in the future, even though it is indeed landed on v4.x-staging |
Sorry, something went wrong.
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2016
… not checked before, this commit checks them. PR-URL: #5546 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2016
… not checked before, this commit checks them. PR-URL: #5546 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
this change (including linting)?
test (or a benchmark) included?
existing APIs, or introduces new ones)?
Affected core subsystem(s)
test
Description of change
Adding test to check process.memoryUsage has correct properties set