deps: backport 8d00c2c from v8 upstream - #5577
Merged
bnoordhuis merged 1 commit intoMar 23, 2016
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Did you really mean me, or is this some kind of magic where you knew I was currently reading it up in the v8 soures? 💯 |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
I'm a mind reader. (Also, a v8-users reader.) |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
:-) Should be working now as expected. Verified it with lldb: ./configure --debug --gdb --xcode make -j8 lldb -- ./node --perf-basic-prof --gdbjit console-test.js (lldb) breakpoint set -name __jit_debug_register_code (lldb) run |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@bnoordhuis ... is this suitable for v4? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
LGTM. Sorry for the delay in reviewing – this got buried in my inbox. @jasnell This is appropriate for backporting to LTS. |
Sorry, something went wrong.
Original commit message:
Unbreak --gdbjit for embedders.
Embedders don't use d8.cc. Move gdbjit initialization to api.cc.
Review URL: https://codereview.chromium.org/1710253002
Fixes: nodejs#2076
PR-URL: nodejs#5577
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
evanlucas
pushed a commit
that referenced
this pull request
Mar 30, 2016
Original commit message:
Unbreak --gdbjit for embedders.
Embedders don't use d8.cc. Move gdbjit initialization to api.cc.
Review URL: https://codereview.chromium.org/1710253002
Fixes: #2076
PR-URL: #5577
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
evanlucas
pushed a commit
that referenced
this pull request
Mar 31, 2016
Original commit message:
Unbreak --gdbjit for embedders.
Embedders don't use d8.cc. Move gdbjit initialization to api.cc.
Review URL: https://codereview.chromium.org/1710253002
Fixes: #2076
PR-URL: #5577
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 8, 2016
Original commit message:
Unbreak --gdbjit for embedders.
Embedders don't use d8.cc. Move gdbjit initialization to api.cc.
Review URL: https://codereview.chromium.org/1710253002
Fixes: #2076
PR-URL: #5577
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Apr 11, 2016
Notable Changes:
deps:
- Fix `--gdbjit` for embedders. Backported from v8 upstream.
(Ben Noordhuis) #5577
etw:
- Correctly display descriptors for ETW events 9 and 23 on the
windows platform.
(João Reis) #5742
querystring:
- Restore throw when attempting to stringify bad surrogate pair.
(Brian White) #5858
MylesBorins
pushed a commit
that referenced
this pull request
Apr 12, 2016
Notable Changes:
deps:
- Fix `--gdbjit` for embedders. Backported from v8 upstream.
(Ben Noordhuis) #5577
etw:
- Correctly display descriptors for ETW events 9 and 23 on the
windows platform.
(João Reis) #5742
querystring:
- Restore throw when attempting to stringify bad surrogate pair.
(Brian White) #5858
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original commit message:
Fixes: #2076
R=@ofrobots?
CI: https://ci.nodejs.org/job/node-test-pull-request/1871/