FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

path: fix normalize for absolutes by evanlucas · Pull Request #5589 · nodejs/node · GitHub

/ node Public

path: fix normalize for absolutes - #5589

Merged
evanlucas merged 1 commit into
nodejs:masterfrom
evanlucas:fixpath
Mar 7, 2016
ConversationCommits (1)ChecksFiles changed
Merged

path: fix normalize for absolutes#5589
evanlucas merged 1 commit into
nodejs:masterfrom
evanlucas:fixpath

Conversation

evanlucas commented Mar 7, 2016

Copy link
Copy Markdown
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
    this change (including linting)?
  • Is the commit message formatted according to CONTRIBUTING.md?
  • If this change fixes a bug (or a performance problem), is a regression
    test (or a benchmark) included?
  • Is a documentation update included (if this change modifies
    existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Affected core subsystem(s)

path

Description of change

Fixes a regression introduced by
b212be0.

path.normalize(''/a/b/c/../../../x/y/z'') should return '/x/y/z'.

Ref: #5585

evanlucas added the path Issues and PRs related to the path subsystem. label Mar 7, 2016

evanlucas commented Mar 7, 2016

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/1872/

/cc @mscdex

MylesBorins commented Mar 7, 2016

Copy link
Copy Markdown
Contributor

LGTM

Fishrock123 added this to the 5.7.2 milestone Mar 7, 2016
evanlucas mentioned this pull request Mar 7, 2016
Merged

jasnell commented Mar 7, 2016

Copy link
Copy Markdown
Member

LGTM

jasnell commented Mar 7, 2016

Copy link
Copy Markdown
Member

Added don't land because I believe the original commit never landed on v4

evanlucas commented Mar 7, 2016

Copy link
Copy Markdown
Contributor Author

Oops, I listed the wrong commit with the regression. It is actually b212be0.

mscdex commented Mar 7, 2016

Copy link
Copy Markdown
Contributor

LGTM

path: fix normalize for absolutes
3d3b45a 
Fixes a regression introduced by
b212be0.

path.normalize(''/a/b/c/../../../x/y/z'') should return '/x/y/z'.

Fixes: nodejs#5585
PR-URL: nodejs#5589
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
evanlucas closed this Mar 7, 2016
evanlucas deleted the fixpath branch March 7, 2016 20:53
evanlucas merged commit 3d3b45a into nodejs:master Mar 7, 2016

evanlucas commented Mar 7, 2016

Copy link
Copy Markdown
Contributor Author

Landed in 3d3b45a. Thanks!

MylesBorins pushed a commit that referenced this pull request Mar 7, 2016
path: fix normalize for absolutes
d9aa699 
Fixes a regression introduced by
b212be0.

path.normalize(''/a/b/c/../../../x/y/z'') should return '/x/y/z'.

Fixes: #5585
PR-URL: #5589
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
MylesBorins pushed a commit that referenced this pull request Mar 7, 2016
2016-03-07, Version 5.7.2 (Stable)
5de263e 
Notable changes

* http_parser:
  * revert d77c3bf which was causing errors inside of http client callbacks to not propagate.
* path:
  * a fix to a regression found in path.resolve for absolute paths with a single character name as the root directory (Evan Lucas) #5589
Fishrock123 pushed a commit that referenced this pull request Mar 8, 2016
path: fix normalize for absolutes
57aa35b 
Fixes a regression introduced by
b212be0.

path.normalize(''/a/b/c/../../../x/y/z'') should return '/x/y/z'.

Fixes: #5585
PR-URL: #5589
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Fishrock123 added a commit that referenced this pull request Mar 8, 2016
2016-03-08, Version 5.8.0 (Stable)
07e6fee 
Notable changes

* path:
  * a fix to a regression found in path.resolve for absolute paths with a single character name as the root directory (Evan Lucas) #5589

PR-URL: #5559
Fishrock123 pushed a commit that referenced this pull request Mar 8, 2016
path: fix normalize for absolutes
f3971f5 
Fixes a regression introduced by
b212be0.

path.normalize(''/a/b/c/../../../x/y/z'') should return '/x/y/z'.

Fixes: #5585
PR-URL: #5589
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Fishrock123 added a commit that referenced this pull request Mar 8, 2016
2016-03-08, Version 5.8.0 (Stable)
fc13773 
Notable changes:

* child_process: “send()” now accepts an options parameter (cjihrig)
#5283
  - Currently the only option is “keepOpen”, which keeps the underlying
socket open after the message is sent.
* constants: “ENGINE_METHOD_RSA” is now correctly exposed (Sam Roberts)
#5463
* Fixed two regressions which originated in v5.7.0:
  - http: Errors inside of http client callbacks now propagate
correctly (Trevor Norris) #5591
  - path: Fixed normalization of absolute paths (Evan Lucas)
#5589
* repl: “start()” no longer requires an options parameter (cjihrig)
#5388
* util: Improved “format()” performance 50-300% (Evan Lucas)
#5360

PR-URL: #5559
Fishrock123 added a commit to Fishrock123/node that referenced this pull request Mar 9, 2016
2016-03-08, Version 5.8.0 (Stable)
3c84752 
Notable changes:

* child_process: “send()” now accepts an options parameter (cjihrig)
nodejs#5283
- Currently the only option is “keepOpen”, which keeps the underlying
socket open after the message is sent.
* constants: “ENGINE_METHOD_RSA” is now correctly exposed (Sam Roberts)
nodejs#5463
* Fixed two regressions which originated in v5.7.0:
  - http: Errors inside of http client callbacks now propagate
correctly (Trevor Norris) nodejs#5591
  - path: Fixed normalization of absolute paths (Evan Lucas)
nodejs#5589
* repl: “start()” no longer requires an options parameter (cjihrig)
nodejs#5388
* util: Improved “format()” performance 50-300% (Evan Lucas)
nodejs#5360

PR-URL: nodejs#5559
MylesBorins mentioned this pull request Mar 11, 2016
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

path Issues and PRs related to the path subsystem.

Projects

None yet

Milestone

5.7.2

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL