lib: refactor code to improve readability - #55995
Merged
nodejs-github-bot merged 1 commit intoNov 27, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## main #55995 +/- ##
==========================================
- Coverage 88.00% 88.00% -0.01%
==========================================
Files 653 653
Lines 188093 188096 +3
Branches 35942 35943 +1
==========================================
+ Hits 165537 165538 +1
- Misses 15734 15737 +3
+ Partials 6822 6821 -1
|
Sorry, something went wrong.
lpinca
approved these changes
Nov 26, 2024
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
LiviaMedeiros
approved these changes
Nov 26, 2024
LiviaMedeiros
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Not sure about readability but one conditional check looks better than eight.
Sorry, something went wrong.
targos
pushed a commit
that referenced
this pull request
Dec 2, 2024
PR-URL: #55995 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name>
This was referenced Dec 6, 2024
Copy link
Copy Markdown
Contributor
|
Backporting to v22.x is blocked by #55404 not being backported yet. If you open a backport PR, please include both commits |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses this suggestion:
#55404 (comment)
@jasnell