test: migrate tests to use node:test module for better test structure for async wrap - #56032
Closed
mertcanaltin wants to merge 1 commit into
Closed
test: migrate tests to use node:test module for better test structure for async wrap#56032mertcanaltin wants to merge 1 commit into
mertcanaltin wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## main #56032 +/- ##
==========================================
+ Coverage 87.95% 87.97% +0.01%
==========================================
Files 656 656
Lines 188372 188372
Branches 35979 35976 -3
==========================================
+ Hits 165687 165718 +31
+ Misses 15851 15827 -24
+ Partials 6834 6827 -7 |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
jasnell
approved these changes
Dec 28, 2024
lpinca
requested changes
Dec 28, 2024
lpinca
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I'm blocking this because there is an approval now and as discussed in other places this is not an improvement in my opinion. I will remove the block once TSC officially decides that a mass refactor to node:test is good for the project.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated AsyncWrap tests to use the node:test module for better structure and maintainability.
this is part of a long pull request: #56024