Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 87.99%. Comparing base (4cf6fab) to head (2a94e99).
Report is 438 commits behind head on main.

@@            Coverage Diff             @@
##             main   #56063      +/-   ##
==========================================
- Coverage   88.00%   87.99%   -0.01%     
==========================================
  Files         656      656              
  Lines      188988   189002      +14     
  Branches    35992    35988       -4     
==========================================
- Hits       166315   166310       -5     
- Misses      15838    15849      +11     
- Partials     6835     6843       +8     

... and 27 files with indirect coverage changes

CI: https://ci.nodejs.org/job/node-test-pull-request/63785/

cc @nodejs/build is there a limitation in macOS regarding this?

12:42:22 ../src/cleanup_queue-inl.h:35:17: error: no member named 'strong_ordering' in namespace 'std'
12:42:22     return std::strong_ordering::greater;
12:42:22            ~~~~~^
12:42:22 ../src/cleanup_queue-inl.h:39:17: error: no member named 'strong_ordering' in namespace 'std'
12:42:22     return std::strong_ordering::less;
12:42:22            ~~~~~^
12:42:22 ../src/cleanup_queue-inl.h:41:15: error: no member named 'strong_ordering' in namespace 'std'
12:42:22   return std::strong_ordering::equivalent;
12:42:22          ~~~~~^

Are you missing an #include <compare>

Are you missing an #include <compare>

Yes, but is it only required on macOS?

cc @nodejs/build This is blocked my macOS infrastructure as well.

20:44:45 ../src/cleanup_queue.cc:3:10: fatal error: 'ranges' file not found
20:44:45 #include <ranges>
20:44:45          ^~~~~~~~
20:44:46 1 error generated.

@anonrig do you know if this is still being blocked by macos test runners?

@anonrig do you know if this is still being blocked by macos test runners?

Yes it is still blocked

@nodejs/platform-macos

CI: https://ci.nodejs.org/job/node-test-pull-request/64844/

CI: https://ci.nodejs.org/job/node-test-pull-request/64860/

Landed in 581b444

It seems this broke the "Test Linux" workflow. Is a GCC update needed?

It's probably the opposite: I guess GCC was updated in the GitHub runners since the last push (two months ago) and includes new warnings.

It seems this broke the "Test Linux" action. Is a GCC update needed?

No the only blocker for this was the macOS build. So Linux shouldn't break unless something changed that's outside of the scope of this Pr in the past 2 months, that broke this pr when it landed.

@targos I am away from keyboard. Can you revert this PR? I can re-land it later. Right now your v8 work is more important.

FWIW the error is:

../src/cleanup_queue.cc:18:32: error: 'greater' may not intend to support class template argument deduction [-Werror,-Wctad-maybe-unsupported]
   18 |   std::ranges::sort(callbacks, std::greater());
      |                                ^
/usr/bin/../lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/stl_function.h:390:12: note: add a deduction guide to suppress this warning
  390 |     struct greater : public binary_function<_Tp, _Tp, bool>
      |            ^
1 error generated.

The "Test Linux" workflow uses clang, not GCC.

The "Test Linux" workflow uses clang, not GCC.

Although FWIW actions/runner-images#11197 back in December updated GNU C++ from 13.2.0 to 13.3.0.

I am away from keyboard. Can you revert this PR? I can re-land it later. Right now your v8 work is more important.

#56846