FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v22.x backport] module: add `findPackageJSON` util by JakobJingleheimer · Pull Request #56074 · nodejs/node · GitHub

/ node Public

[v22.x backport] module: add findPackageJSON util - #56074

Merged
aduh95 merged 2 commits into
nodejs:v22.x-stagingfrom
JakobJingleheimer:backport/add-findPackageJSON-util
Dec 10, 2024
ConversationCommits (2)ChecksFiles changed
Merged

[v22.x backport] module: add findPackageJSON util#56074
aduh95 merged 2 commits into
nodejs:v22.x-stagingfrom
JakobJingleheimer:backport/add-findPackageJSON-util

Conversation

JakobJingleheimer commented Nov 29, 2024

Copy link
Copy Markdown
Member

PR-URL: #55412
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com

nodejs-github-bot commented Nov 29, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. labels Nov 29, 2024

aduh95 commented Nov 29, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Can you also backport #55543 in the same PR please?

JakobJingleheimer commented Nov 29, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

Can you also backport #55543 in the same PR please?

Looks like the answer is yes 🙂

#55543 (comment)

JakobJingleheimer commented Nov 29, 2024

Copy link
Copy Markdown
Member Author

Can you also backport #55543 in the same PR please?

Well that was easy 😁

aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2024

nodejs-github-bot commented Nov 29, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63780/

nodejs-github-bot commented Nov 29, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63794/

nodejs-github-bot commented Nov 30, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63798/

JakobJingleheimer commented Nov 30, 2024

Copy link
Copy Markdown
Member Author

It looks like everything is green but coverage, which seems bogus: it passed on the original. To my knowledge, it already has full coverage (aside from #55822), so I'm not sure how to address this.

JakobJingleheimer mentioned this pull request Dec 7, 2024
Merged
JakobJingleheimer added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 10, 2024
JakobJingleheimer and others added 2 commits December 10, 2024 22:15
module: add findPackageJSON util
807f34f 
PR-URL: nodejs#55412
Backport-PR-URL: nodejs#56074
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
module: simplify findPackageJSON implementation
4f85047 
PR-URL: nodejs#55543
Backport-PR-URL: nodejs#56074
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: nodejs#55412
aduh95 force-pushed the backport/add-findPackageJSON-util branch from 3a67999 to 4f85047 Compare December 10, 2024 21:21
aduh95 merged commit 4f85047 into nodejs:v22.x-staging Dec 10, 2024

aduh95 commented Dec 10, 2024

Copy link
Copy Markdown
Contributor

Landed in 552a182...4f85047

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

anonrig anonrig approved these changes
aduh95 aduh95 approved these changes
ruyadorno Awaiting requested review from ruyadorno

Assignees

No one assigned

Labels

lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL