| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
Please add a test case |
Sorry, something went wrong.
Done 💯 |
Sorry, something went wrong.
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## main #56264 +/- ##
==========================================
- Coverage 88.55% 88.54% -0.01%
==========================================
Files 657 657
Lines 190243 190245 +2
Branches 36536 36542 +6
==========================================
- Hits 168461 168457 -4
- Misses 14963 14968 +5
- Partials 6819 6820 +1
|
Sorry, something went wrong.
There was a problem hiding this comment.
I am actually open to (prefer to) revert and add a test as well
Sorry, something went wrong.
There was a problem hiding this comment.
Had a private chat with @jakecastelli. I think it's better to revert this and add a test.
@origranot Would you like to raise a new PR to revert the commit and introduce a new commit to add the test?
Sorry, something went wrong.
Yea, I am on it. Thanks! |
Sorry, something went wrong.
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Fixes #56263
Another suggestion is to force developers to pass a string, else throw an ERR_INVALID_ARG_TYPE but this should consider a breaking change.
Looking forward for your feedback!