test: remove flaky test-pipe-file-to-http designation - #56472
Closed
lpinca wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
The original issue is likely the same as other tests that time out. Refs: nodejs#54918 Refs: nodejs#53595 Refs: nodejs#53751
Copy link
Copy Markdown
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## main #56472 +/- ##
==========================================
+ Coverage 88.53% 88.54% +0.01%
==========================================
Files 657 657
Lines 190719 190761 +42
Branches 36605 36614 +9
==========================================
+ Hits 168848 168910 +62
+ Misses 15040 15037 -3
+ Partials 6831 6814 -17 |
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
mhdawson
approved these changes
Jan 6, 2025
mhdawson
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
jasnell
approved these changes
Jan 6, 2025
jasnell
pushed a commit
that referenced
this pull request
Jan 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original issue is likely the same as other tests that time out.
Refs: #54918
Refs: #53595
Refs: #53751