FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: add test for known issue with event emitters by Trott · Pull Request #5649 · nodejs/node · GitHub

/ node Public

test: add test for known issue with event emitters - #5649

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:proto-noto
Closed

test: add test for known issue with event emitters#5649
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:proto-noto

Conversation

Trott commented Mar 10, 2016

Copy link
Copy Markdown
Member
  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
    this change (including linting)?
  • Is the commit message formatted according to [CONTRIBUTING.md][0]?

Affected core subsystem(s)

test, events

Description of change

Add test for known issue where a valid event name may be rejected.

Refs: #728

Trott added events Issues and PRs related to the events subsystem / EventEmitter. test Issues and PRs related to the tests. lts-watch-v4.x labels Mar 10, 2016
mscdex mentioned this pull request Mar 11, 2016
4 tasks

jasnell commented Mar 11, 2016

Copy link
Copy Markdown
Member

LGTM

cjihrig commented Mar 12, 2016

Copy link
Copy Markdown
Contributor

Closing, with permission, in favor of 10bc673

cjihrig closed this Mar 12, 2016
Trott deleted the proto-noto branch January 13, 2022 22:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

events Issues and PRs related to the events subsystem / EventEmitter. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL