FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: add BaseObjectPtr nullptr operations by legendecas · Pull Request #56585 · nodejs/node · GitHub

/ node Public

src: add BaseObjectPtr nullptr operations - #56585

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
legendecas:base-object-ptr-nullptr
Apr 10, 2025
ConversationCommits (1)ChecksFiles changed
Merged

src: add BaseObjectPtr nullptr operations#56585
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
legendecas:base-object-ptr-nullptr

Conversation

legendecas commented Jan 13, 2025

Copy link
Copy Markdown
Member

Allow comparing a BaseObjectPtr or implicitly construct a
BaseObjectPtr with nullptr.

nodejs-github-bot commented Jan 13, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http2
  • @nodejs/net

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jan 13, 2025
legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 13, 2025
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 13, 2025

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view
jasnell reviewed Jan 13, 2025
View reviewed changes
Comment thread src/node_contextify.cc Outdated
addaleax reviewed Jan 13, 2025
View reviewed changes
Comment thread src/base_object-inl.h Outdated
Comment thread src/node_contextify.cc Outdated
legendecas force-pushed the base-object-ptr-nullptr branch from 7d35dba to 06cb322 Compare January 22, 2025 11:07
legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 22, 2025
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 22, 2025

This comment was marked as outdated.

Sign in to view
src: add BaseObjectPtr nullptr operations
0d69bb8 
Allow comparing a `BaseObjectPtr` or implicitly construct a
`BaseObjectPtr` with `nullptr`.
legendecas force-pushed the base-object-ptr-nullptr branch from 06cb322 to 0d69bb8 Compare January 23, 2025 09:47

legendecas commented Jan 23, 2025

Copy link
Copy Markdown
Member Author

Rebased to fix the failures that were on the main branch

legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 23, 2025
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 23, 2025

This comment was marked as outdated.

Sign in to view

nodejs-github-bot commented Jan 23, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64681/

legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 10, 2025
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 10, 2025

nodejs-github-bot commented Apr 10, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66187/

legendecas added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 10, 2025
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 10, 2025
nodejs-github-bot merged commit f692878 into nodejs:main Apr 10, 2025

nodejs-github-bot commented Apr 10, 2025

Copy link
Copy Markdown
Collaborator

Landed in f692878

legendecas deleted the base-object-ptr-nullptr branch April 10, 2025 16:43
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
src: add BaseObjectPtr nullptr operations
9f691e8 
Allow comparing a `BaseObjectPtr` or implicitly construct a
`BaseObjectPtr` with `nullptr`.

PR-URL: #56585
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
RafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
src: add BaseObjectPtr nullptr operations
3435001 
Allow comparing a `BaseObjectPtr` or implicitly construct a
`BaseObjectPtr` with `nullptr`.

PR-URL: #56585
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
aduh95 pushed a commit that referenced this pull request May 6, 2025
src: add BaseObjectPtr nullptr operations
1869b92 
Allow comparing a `BaseObjectPtr` or implicitly construct a
`BaseObjectPtr` with `nullptr`.

PR-URL: #56585
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
src: add BaseObjectPtr nullptr operations
50958c8 
Allow comparing a `BaseObjectPtr` or implicitly construct a
`BaseObjectPtr` with `nullptr`.

PR-URL: #56585
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
aduh95 pushed a commit that referenced this pull request May 16, 2025
src: add BaseObjectPtr nullptr operations
dd94236 
Allow comparing a `BaseObjectPtr` or implicitly construct a
`BaseObjectPtr` with `nullptr`.

PR-URL: #56585
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
aduh95 pushed a commit that referenced this pull request May 17, 2025
src: add BaseObjectPtr nullptr operations
8b3dd43 
Allow comparing a `BaseObjectPtr` or implicitly construct a
`BaseObjectPtr` with `nullptr`.

PR-URL: #56585
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
aduh95 pushed a commit that referenced this pull request May 18, 2025
src: add BaseObjectPtr nullptr operations
682d558 
Allow comparing a `BaseObjectPtr` or implicitly construct a
`BaseObjectPtr` with `nullptr`.

PR-URL: #56585
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
github-actions Bot mentioned this pull request May 19, 2025
Merged
aduh95 pushed a commit that referenced this pull request May 19, 2025
src: add BaseObjectPtr nullptr operations
e00c1ec 
Allow comparing a `BaseObjectPtr` or implicitly construct a
`BaseObjectPtr` with `nullptr`.

PR-URL: #56585
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
ghost mentioned this pull request Jun 8, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
addaleax addaleax approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL