Review requested:

• @nodejs/net

Please add notable-change label.
These docs will need to be updated

Can you articulate why we should be doubling this? The other discussion is very long.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.21%. Comparing base (50d405a) to head (92e1aaa).
⚠️ Report is 3222 commits behind head on main.

@@            Coverage Diff             @@
##             main   #56738      +/-   ##
==========================================
- Coverage   89.22%   89.21%   -0.02%     
==========================================
  Files         663      663              
  Lines      191974   192012      +38     
  Branches    36926    36933       +7     
==========================================
+ Hits       171286   171294       +8     
- Misses      13561    13575      +14     
- Partials     7127     7143      +16     

... and 33 files with indirect coverage changes

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hvanness Can you please update failing tests? Once you do that, this PR will LGTM.

Can you articulate why we should be doubling this? The other discussion is very long.

This is a socket connection hard timeout, which should eventually be removed from the implementation.

For now, increasing it to 500ms resolves the majority of breaking cases:
250ms is about how long it takes to connect from Australia to US East.

PS. I maintain that parallel connections are equally safe as serial. If it is possible to stop a connection to make it serial, then it must be possible to stop all connections when one parallel connection is established.

PS. I maintain that parallel connections are equally safe as serial. If it is possible to stop a connection to make it serial, then it must be possible to stop all connections when one parallel connection is established.

Unfortunately that's not the case. Sockets are created at C++ layer and linked to JS objects. The code is structured to have one C++ socket per JS socket and having multiple would impact significant refactoring in the code, especially w.r.t. callbacks established in many other places of the code (like TLS).

Temporarily?
Just let it stay at 500ms, it's probably not even enough considering the actual latency the services experience.

My problem with this PR is that while increasing the timeout is semver-minor, decreasing would be semver-major (unless we opt to revert the change, which is not always a good idea).

I'll bring this into the next TSC to get a line of action.

Applied the baking-for-lts labelled as discussed in today's TSC meeting. This label signifies that this should be considered for LTS versions of Node.js, but not immediately backported because we would like to see if any issues arise when this is included on a current release first.

@hvanness If you fix the commit we will be happy to land this.

@hvanness did you plan to make the requested change to this commit so they could land it?

Can you adjust the first commit to follow our guidelines?

This pull request has been marked as stale due to 210 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.

@hvanness are there any intentions to continue this?

I'm facing similar issues and would love to see this merged, thanks!