test: refactor http-end-throw-socket-handling - #5676
Closed
santigimeno wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Remove timer to avoid the test to timeout occasionally.
Copy link
Copy Markdown
Contributor
|
CI: https://ci.nodejs.org/job/node-test-pull-request/1909/ |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
LGTM |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
This one went under the radar. I'll be merging it in 24hs if no one objects. |
Sorry, something went wrong.
claudiorodriguez
pushed a commit
that referenced
this pull request
Apr 2, 2016
Remove timer to avoid the test timing out occasionally. PR-URL: #5676 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 5, 2016
Remove timer to avoid the test timing out occasionally. PR-URL: #5676 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
This was referenced Apr 5, 2016
Closed
Merged
Copy link
Copy Markdown
Member
|
+1
|
Sorry, something went wrong.
MylesBorins
pushed a commit
that referenced
this pull request
May 3, 2016
Remove timer to avoid the test timing out occasionally. PR-URL: #5676 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 6, 2016
Remove timer to avoid the test timing out occasionally. PR-URL: #5676 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 18, 2016
Remove timer to avoid the test timing out occasionally. PR-URL: #5676 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
this change (including linting)?
test (or a benchmark) included?
existing APIs, or introduces new ones)?
Affected core subsystem(s)
test
Description of change
Remove timer to avoid the test to timeout occasionally.
I have been getting this error on OS X:
=== release test-http-end-throw-socket-handling === Path: parallel/test-http-end-throw-socket-handling /Users/sgimeno/node/node/test/parallel/test-http-end-throw-socket-handling.js:35 throw new Error('Taking too long!'); ^ Error: Taking too long! at ._onTimeout (/Users/sgimeno/node/node/test/parallel/test-http-end-throw-socket-handling.js:35:9) at Timer.unrefdHandle (timers.js:454:14) Command: out/Release/node /Users/sgimeno/node/node/test/parallel/test-http-end-throw-socket-handling.js