FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v20.x backport] deps: V8: backport 9ab40592f697 by kxxt · Pull Request #56782 · nodejs/node · GitHub

/ node Public

[v20.x backport] deps: V8: backport 9ab40592f697 - #56782

Closed
kxxt wants to merge 1 commit into
nodejs:v20.x-stagingfrom
kxxt:v20-rv-fix
ConversationCommits (1)ChecksFiles changed
Closed

[v20.x backport] deps: V8: backport 9ab40592f697#56782
kxxt wants to merge 1 commit into
nodejs:v20.x-stagingfrom
kxxt:v20-rv-fix

Conversation

kxxt commented Jan 27, 2025

Copy link
Copy Markdown
Member

Manual backport for v20.x of #56781

Original commit message:

[riscv] Flush icache in both local and remote harts

Fix the I-Cache flush flag according to the implementation of flush_icache_mm in Linux kernel.

Change-Id: I6e6b1f56c377c2c0a629e170737bfac6c357ce8d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6080611
Commit-Queue: Yahan Lu (LuYahan) <yahan@iscas.ac.cn>
Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn>
Cr-Commit-Position: refs/heads/main@{#97673}

Refs: v8/v8@9ab4059

nodejs-github-bot commented Jan 27, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update

nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v20.x v8 engine Issues and PRs related to the V8 dependency. labels Jan 27, 2025
kxxt mentioned this pull request Jan 27, 2025
Merged
aduh95 changed the title deps: V8: backport 9ab40592f697 [v20.x backport] deps: V8: backport 9ab40592f697 Jan 27, 2025

aduh95 commented Jan 27, 2025

Copy link
Copy Markdown
Contributor

We'd need to wait for #56781 to land, and we should amend the commit message to use the metadata of the other PR

kxxt added a commit to kxxt/archriscv-packages that referenced this pull request Jan 27, 2025
updpatch: nodejs 23.4.0-1
84cf8d0 
- Switch compiler to clang, this workarounds https://archriscv.felixc.at/.status/log.htm?url=logs/389-ds-base/389-ds-base-3.1.1-3.log
  See more details in riscv-forks/electron#7
- Cherry-pick icache flush fix, upstreamed:
  - nodejs/node#56781
  - nodejs/node#56782
- Should still need nocheck
kxxt mentioned this pull request Jan 27, 2025
Merged
kxxt added a commit to kxxt/archriscv-packages that referenced this pull request Jan 27, 2025
updpatch: nodejs 23.4.0-1
c1addc7 
- Switch compiler to clang, this workarounds https://archriscv.felixc.at/.status/log.htm?url=logs/389-ds-base/389-ds-base-3.1.1-3.log
  See more details in riscv-forks/electron#7
- Cherry-pick icache flush fix, upstreamed:
  - nodejs/node#56781
  - nodejs/node#56782
- Should still need nocheck
felixonmars pushed a commit to felixonmars/archriscv-packages that referenced this pull request Jan 28, 2025
updpatch: nodejs 23.4.0-1
330c57b 
- Switch compiler to clang, this workarounds https://archriscv.felixc.at/.status/log.htm?url=logs/389-ds-base/389-ds-base-3.1.1-3.log
  See more details in riscv-forks/electron#7
- Cherry-pick icache flush fix, upstreamed:
  - nodejs/node#56781
  - nodejs/node#56782
- Should still need nocheck
marco-ippolito added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jan 28, 2025

nodejs-github-bot commented Jan 28, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64808/

nodejs-github-bot commented Jan 28, 2025

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6379/

nodejs-github-bot commented Jan 28, 2025

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6379/

nodejs-github-bot commented Jan 28, 2025

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6379/

marco-ippolito commented Feb 11, 2025

Copy link
Copy Markdown
Member

can you rebase please, the issue on smartos should have been fixed.

deps: V8: backport 9ab40592f697
2baef44 
Original commit message:

    [riscv] Flush icache in both local and remote harts

    Fix the I-Cache flush flag according to the implementation of flush_icache_mm in Linux kernel.

    Change-Id: I6e6b1f56c377c2c0a629e170737bfac6c357ce8d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6080611
    Commit-Queue: Yahan Lu (LuYahan) <yahan@iscas.ac.cn>
    Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn>
    Cr-Commit-Position: refs/heads/main@{#97673}

Refs: v8/v8@9ab4059
Co-authored-by: kxxt <rsworktech@outlook.com>

kxxt commented Feb 11, 2025

Copy link
Copy Markdown
Member Author

can you rebase please, the issue on smartos should have been fixed.

Rebased. Thanks for the ping.

BTW should I do anything manually targeting v22.x. #56781 should apply to v22.x (except the v8_embedder_string part). Are there any automatic way to pick #56781 into v22.x or should I open another PR like this one?

marco-ippolito commented Feb 11, 2025

Copy link
Copy Markdown
Member

If lands cleanly it will be picked up automatically

marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 11, 2025
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 11, 2025

nodejs-github-bot commented Feb 11, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65137/

nodejs-github-bot commented Feb 11, 2025

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6408/

nodejs-github-bot commented Feb 11, 2025

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6408/

nodejs-github-bot commented Feb 11, 2025

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6408/

marco-ippolito commented Feb 11, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Landed in 5c9a397

marco-ippolito pushed a commit that referenced this pull request Feb 11, 2025
deps: V8: backport 9ab40592f697
5c9a397 
Original commit message:

    [riscv] Flush icache in both local and remote harts

    Fix the I-Cache flush flag according to the implementation of flush_icache_mm in Linux kernel.

    Change-Id: I6e6b1f56c377c2c0a629e170737bfac6c357ce8d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6080611
    Commit-Queue: Yahan Lu (LuYahan) <yahan@iscas.ac.cn>
    Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn>
    Cr-Commit-Position: refs/heads/main@{#97673}

Refs: v8/v8@9ab4059
PR-URL: #56781
Backport-PR-URL: #56782
Co-authored-by: kxxt <rsworktech@outlook.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

richardlau richardlau approved these changes
marco-ippolito marco-ippolito approved these changes
+1 more reviewer
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL