module: the node_modules paths always should be placed below the current directory - #5690
Closed
watilde wants to merge 1 commit into
Closed
module: the node_modules paths always should be placed below the current directory#5690watilde wants to merge 1 commit into
watilde wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Oops, this is duplicated with #5689. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@watilde sorry! By this I learned I should always leave a "I'm on it" comment when starting on something. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@phillipj nvm 😊 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
this change (including linting)?
test (or a benchmark) included?
existing APIs, or introduces new ones)?
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Affected core subsystem(s)
repl
Description of change
Fix #5684. The result of the require("module")._resolveLookupPaths('./') in repl
Before:
[ './', [ '/Users/watilde/Development/tmp/repro/node_modules', '/Users/watilde/Development/tmp/node_modules', '/Users/watilde/Development/node_modules', '/Users/watilde/node_modules', '/Users/node_modules', '/node_modules', '.', '/Users/watilde/.node_modules', '/Users/watilde/.node_libraries', '/Users/watilde/.nodebrew/node/v5.4.0/lib/node' ] ]After:
[ './', [ '/Users/watilde/Development/tmp/repro', '/Users/watilde/Development/tmp/repro/node_modules', '/Users/watilde/Development/tmp/node_modules', '/Users/watilde/Development/node_modules', '/Users/watilde/node_modules', '/Users/node_modules', '/node_modules', '/Users/watilde/.node_modules', '/Users/watilde/.node_libraries', '/Users/watilde/Development/node/out/lib/node' ] ]will update test/parallel/test-repl.js