22.14.0 'Jod' (LTS) release proposal - #56910
Merged
aduh95 merged 205 commits intoFeb 11, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
PR-URL: #56707 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
PR-URL: #55066 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #56276 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
V8 should be built with -fvisibility=hidden, otherwise the resulting binary would contain unnecessary symbols. In particular, on macOS, this leads to 5000+ weak symbols resolved at runtime, leading to a startup regression. On macOS this also reduces the binary size about ~10MB. It's only enabled on macOS in this patch as gcc can time out or run out of memory on some machines in the CI with -fvisibility=hidden. PR-URL: #56275 Fixes: nodejs/performance#180 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Daniel Lemire <daniel@lemire.me> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: #56283 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #56295 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
PR-URL: #56282 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jason Zhang <xzha4350@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
When the source map data are invalid json strings, skip construct `SourceMap` on it. Additionally, suppress exceptions on source map lookups and fix test runners crash on invalid source maps. PR-URL: #56299 Refs: #56296 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Only invalidates source map lookup cache when a new source map is found. This improves when user codes interleave with builtin functions, like `array.map`. PR-URL: #56299 Refs: #56296 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
PR-URL: #56067 Fixes: #56014 Refs: whatwg/streams#1333 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
PR-URL: #56162 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com>
We are in the process of updating macOS to version 13 in the Jenkins CI, but unfortunately this is taking longer than expected. Add it to the GitHub actions test matrix so that we have some coverage. Refs: nodejs/build#3686 PR-URL: #56307 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
`btoa` only supports latin-1 charset and produces invalid source mapping urls. PR-URL: #56315 Refs: #56296 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #56317 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
PR-URL: #56300 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #56325 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name>
PR-URL: #56332 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #56334 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Migrate the eval tests in the `test/message` folder from Python to JS. PR-URL: #50482 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
It was excluded as it was failing intermittently. Likely that s390 was just so fast times were rounded down to 0. Increase the spin time on s390x only. Signed-off-by: Michael Dawson <midawson@redhat.com> PR-URL: #56228 Refs: #41286 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: #56341 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
PR-URL: #55811 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jason Zhang <xzha4350@gmail.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #56345 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #56346 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
aduh95
added a commit
that referenced
this pull request
Feb 6, 2025
Notable changes: crypto: * update root certificates to NSS 3.107 (Node.js GitHub Bot) #56566 fs: * (SEMVER-MINOR) allow `exclude` option in globs to accept glob patterns (Daeyeon Jeong) #56489 lib: * (SEMVER-MINOR) add typescript support to STDIN eval (Marco Ippolito) #56359 module: * (SEMVER-MINOR) add ERR_UNSUPPORTED_TYPESCRIPT_SYNTAX (Marco Ippolito) #56610 * (SEMVER-MINOR) add `findPackageJSON` util (Jacob Smith) #55412 process: * (SEMVER-MINOR) add process.ref() and process.unref() methods (James M Snell) #56400 sqlite: * (SEMVER-MINOR) support TypedArray and DataView in `StatementSync` (Alex Yang) #56385 src: * (SEMVER-MINOR) add --disable-sigusr1 to prevent signal i/o thread (Rafael Gonzaga) #56441 src,worker: * (SEMVER-MINOR) add isInternalWorker (Carlos Espa) #56469 test_runner: * (SEMVER-MINOR) add TestContext.prototype.waitFor() (Colin Ihrig) #56595 * (SEMVER-MINOR) add t.assert.fileSnapshot() (Colin Ihrig) #56459 * (SEMVER-MINOR) add assert.register() API (Colin Ihrig) #56434 worker: * (SEMVER-MINOR) add eval ts input (Marco Ippolito) #56394 PR-URL: #56910
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
xtexx
added a commit
to AOSC-Dev/aosc-os-abbs
that referenced
this pull request
Feb 8, 2025
This backports node update of corepack to 0.31.0, updating npmjs.org
keys pinned by corepack.
The patch should be removed after nodejs 22.14.0 proposal gets released.
This should fix the following error:
corepack install -g pnpm@10.2.1
Installing pnpm@10.2.1...
Internal Error: Cannot find matching keyid: {"signatures":[{"sig":"MEYCIQDkZyZZmBzkRcQowEEFiEcGp4/xV8GBLXxTEzz9QstrsAIhAPx6tvZixjTub6GPqJa82vcWFhUU39JCtoJvcoRK/K39","keyid":"SHA256:DhQ8wR5APBvFHLF/+Tc+AYvPOdTpcIDqOhxsBHRwC7U"}],"keys":[{"expires":null,"keyid":"SHA256:jl3bwswu80PjjokCgh0o2w5c2U4LhQAE57gj9cz1kzA","keytype":"ecdsa-sha2-nistp256","scheme":"ecdsa-sha2-nistp256","key":"MFkwEwYHKoZIzj0CAQYIKoZIzj0DAQcDQgAE1Olb3zMAFFxXKHiIkQO5cJ3Yhl5i6UPp+IhuteBJbuHcA5UogKo0EWtlWwW6KSaKoTNEYL7JlCQiVnkhBktUgg=="}]}
Link: nodejs/node#56910
Link: pnpm/pnpm#9014
Link: nodejs/corepack#612
Link: misskey-dev/misskey#15386
Link: https://github.com/nodejs/corepack/releases/tag/v0.31.0
Link: nodejs/node@63c1859
Link: nodejs/node#56795
Backport-of: 63c1859e019465cbb0b6b46ba0d481fb41d94a22
Reviewed-by: xtex <xtex@aosc.io>
Signed-off-by: xtex <xtex@aosc.io>
6 tasks
MingcongBai
pushed a commit
to AOSC-Dev/aosc-os-abbs
that referenced
this pull request
Feb 8, 2025
This backports node update of corepack to 0.31.0, updating npmjs.org
keys pinned by corepack.
The patch should be removed after nodejs 22.14.0 proposal gets released.
This should fix the following error:
corepack install -g pnpm@10.2.1
Installing pnpm@10.2.1...
Internal Error: Cannot find matching keyid: {"signatures":[{"sig":"MEYCIQDkZyZZmBzkRcQowEEFiEcGp4/xV8GBLXxTEzz9QstrsAIhAPx6tvZixjTub6GPqJa82vcWFhUU39JCtoJvcoRK/K39","keyid":"SHA256:DhQ8wR5APBvFHLF/+Tc+AYvPOdTpcIDqOhxsBHRwC7U"}],"keys":[{"expires":null,"keyid":"SHA256:jl3bwswu80PjjokCgh0o2w5c2U4LhQAE57gj9cz1kzA","keytype":"ecdsa-sha2-nistp256","scheme":"ecdsa-sha2-nistp256","key":"MFkwEwYHKoZIzj0CAQYIKoZIzj0DAQcDQgAE1Olb3zMAFFxXKHiIkQO5cJ3Yhl5i6UPp+IhuteBJbuHcA5UogKo0EWtlWwW6KSaKoTNEYL7JlCQiVnkhBktUgg=="}]}
Link: nodejs/node#56910
Link: pnpm/pnpm#9014
Link: nodejs/corepack#612
Link: misskey-dev/misskey#15386
Link: https://github.com/nodejs/corepack/releases/tag/v0.31.0
Link: nodejs/node@63c1859
Link: nodejs/node#56795
Backport-of: 63c1859e019465cbb0b6b46ba0d481fb41d94a22
Reviewed-by: xtex <xtex@aosc.io>
Signed-off-by: xtex <xtex@aosc.io>
Copy link
Copy Markdown
Contributor
|
@aduh95 I'm not sure what the policy is on quick patch releases in the Node.js release lifecycle, but due to the high activity on the Corepack Cannot find matching keyid failure (nodejs/corepack#612), does it fit the release lifecycle to release a hotfix patch version 22.13.2 with #56795 before 22.14.0 is released? We encountered this problem today after upgrading to pnpm v10 and then deploying to Netlify. We would like to use the current recommended workaround of installing latest Corepack (eg. using npm install --global corepack@latest), but:
On the other hand, I guess there's not a lot of time until 2025-02-12, the current planned release date of 22.14.0... |
Sorry, something went wrong.
This comment was marked as off-topic.
Copy link
Copy Markdown
Contributor
|
The best I can do is move the release date to tomorrow. FWIW there's a RC available, in case that could unblock you: https://nodejs.org/download/rc/v22.14.0-rc.1/ |
Sorry, something went wrong.
Notable changes: crypto: * update root certificates to NSS 3.107 (Node.js GitHub Bot) #56566 fs: * (SEMVER-MINOR) allow `exclude` option in globs to accept glob patterns (Daeyeon Jeong) #56489 lib: * (SEMVER-MINOR) add typescript support to STDIN eval (Marco Ippolito) #56359 module: * (SEMVER-MINOR) add ERR_UNSUPPORTED_TYPESCRIPT_SYNTAX (Marco Ippolito) #56610 * (SEMVER-MINOR) add `findPackageJSON` util (Jacob Smith) #55412 process: * (SEMVER-MINOR) add process.ref() and process.unref() methods (James M Snell) #56400 sqlite: * (SEMVER-MINOR) support TypedArray and DataView in `StatementSync` (Alex Yang) #56385 src: * (SEMVER-MINOR) add --disable-sigusr1 to prevent signal i/o thread (Rafael Gonzaga) #56441 src,worker: * (SEMVER-MINOR) add isInternalWorker (Carlos Espa) #56469 test_runner: * (SEMVER-MINOR) add TestContext.prototype.waitFor() (Colin Ihrig) #56595 * (SEMVER-MINOR) add t.assert.fileSnapshot() (Colin Ihrig) #56459 * (SEMVER-MINOR) add assert.register() API (Colin Ihrig) #56434 worker: * (SEMVER-MINOR) add eval ts input (Marco Ippolito) #56394 PR-URL: #56910
aduh95
force-pushed
the
v22.14.0-proposal
branch
from
c239f54 to
5d2feb2
Compare
February 10, 2025 16:23
aduh95
approved these changes
Feb 11, 2025
aduh95
added a commit
that referenced
this pull request
Feb 11, 2025
Notable changes: crypto: * update root certificates to NSS 3.107 (Node.js GitHub Bot) #56566 fs: * (SEMVER-MINOR) allow `exclude` option in globs to accept glob patterns (Daeyeon Jeong) #56489 lib: * (SEMVER-MINOR) add typescript support to STDIN eval (Marco Ippolito) #56359 module: * (SEMVER-MINOR) add ERR_UNSUPPORTED_TYPESCRIPT_SYNTAX (Marco Ippolito) #56610 * (SEMVER-MINOR) add `findPackageJSON` util (Jacob Smith) #55412 process: * (SEMVER-MINOR) add process.ref() and process.unref() methods (James M Snell) #56400 sqlite: * (SEMVER-MINOR) support TypedArray and DataView in `StatementSync` (Alex Yang) #56385 src: * (SEMVER-MINOR) add --disable-sigusr1 to prevent signal i/o thread (Rafael Gonzaga) #56441 src,worker: * (SEMVER-MINOR) add isInternalWorker (Carlos Espa) #56469 test_runner: * (SEMVER-MINOR) add TestContext.prototype.waitFor() (Colin Ihrig) #56595 * (SEMVER-MINOR) add t.assert.fileSnapshot() (Colin Ihrig) #56459 * (SEMVER-MINOR) add assert.register() API (Colin Ihrig) #56434 worker: * (SEMVER-MINOR) add eval ts input (Marco Ippolito) #56394 PR-URL: #56910
aduh95
added a commit
to aduh95/nodejs.org
that referenced
this pull request
Feb 11, 2025
aduh95
added a commit
to aduh95/nodejs.org
that referenced
this pull request
Feb 11, 2025
5 tasks
github-merge-queue Bot
pushed a commit
to nodejs/nodejs.org
that referenced
this pull request
Feb 11, 2025
Copy link
Copy Markdown
Contributor
|
@aduh95 thanks for the release! I can confirm that Node.js v22.14.0 with Corepack 0.31.0 resolves the Cannot find matching keyid error, also on Netlify. I posted about the new version on social media: |
Sorry, something went wrong.
acidiney
pushed a commit
to acidiney/node
that referenced
this pull request
Feb 23, 2025
Notable changes: crypto: * update root certificates to NSS 3.107 (Node.js GitHub Bot) nodejs#56566 fs: * (SEMVER-MINOR) allow `exclude` option in globs to accept glob patterns (Daeyeon Jeong) nodejs#56489 lib: * (SEMVER-MINOR) add typescript support to STDIN eval (Marco Ippolito) nodejs#56359 module: * (SEMVER-MINOR) add ERR_UNSUPPORTED_TYPESCRIPT_SYNTAX (Marco Ippolito) nodejs#56610 * (SEMVER-MINOR) add `findPackageJSON` util (Jacob Smith) nodejs#55412 process: * (SEMVER-MINOR) add process.ref() and process.unref() methods (James M Snell) nodejs#56400 sqlite: * (SEMVER-MINOR) support TypedArray and DataView in `StatementSync` (Alex Yang) nodejs#56385 src: * (SEMVER-MINOR) add --disable-sigusr1 to prevent signal i/o thread (Rafael Gonzaga) nodejs#56441 src,worker: * (SEMVER-MINOR) add isInternalWorker (Carlos Espa) nodejs#56469 test_runner: * (SEMVER-MINOR) add TestContext.prototype.waitFor() (Colin Ihrig) nodejs#56595 * (SEMVER-MINOR) add t.assert.fileSnapshot() (Colin Ihrig) nodejs#56459 * (SEMVER-MINOR) add assert.register() API (Colin Ihrig) nodejs#56434 worker: * (SEMVER-MINOR) add eval ts input (Marco Ippolito) nodejs#56394 PR-URL: nodejs#56910
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- [82a9000e9e] - crypto: update root certificates to NSS 3.107 (Node.js GitHub Bot) #56566
- [b7fe54fc88] - (SEMVER-MINOR) fs: allow exclude option in globs to accept glob patterns (Daeyeon Jeong) #56489
- [3ac92ef607] - (SEMVER-MINOR) lib: add typescript support to STDIN eval (Marco Ippolito) #56359
- [1614e8e7bc] - (SEMVER-MINOR) module: add ERR_UNSUPPORTED_TYPESCRIPT_SYNTAX (Marco Ippolito) #56610
- [6d6cffa9cc] - (SEMVER-MINOR) module: add findPackageJSON util (Jacob Smith) #55412
- [d35333ae18] - (SEMVER-MINOR) process: add process.ref() and process.unref() methods (James M Snell) #56400
- [07ff3ddcb5] - (SEMVER-MINOR) sqlite: support TypedArray and DataView in StatementSync (Alex Yang) #56385
- [94d3fe1b62] - (SEMVER-MINOR) src: add --disable-sigusr1 to prevent signal i/o thread (Rafael Gonzaga) #56441
- [5afffb4415] - (SEMVER-MINOR) src,worker: add isInternalWorker (Carlos Espa) #56469
- [697a851fb3] - (SEMVER-MINOR) test_runner: add TestContext.prototype.waitFor() (Colin Ihrig) #56595
- [047537b48c] - (SEMVER-MINOR) test_runner: add t.assert.fileSnapshot() (Colin Ihrig) #56459
- [926cf84e95] - (SEMVER-MINOR) test_runner: add assert.register() API (Colin Ihrig) #56434
- [c658a8afdf] - (SEMVER-MINOR) worker: add eval ts input (Marco Ippolito) #56394
Commits