src: lock the isolate properly in IsolateData destructor - #57031
Merged
nodejs-github-bot merged 2 commits intoFeb 15, 2025
Merged
src: lock the isolate properly in IsolateData destructor#57031nodejs-github-bot merged 2 commits into
nodejs-github-bot merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Otherwise it may fail the DCHECK that uses the locked thread as a fast path to get the current thread.
legendecas
approved these changes
Feb 13, 2025
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Looks like we can't do that on the main branch. Feel free to push the commit to #56959 |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
It seems it also fails in the V8 13.3 branch in the cctest, I suspect that this is also exposing that we aren't using HandleScope properly throughout the codebase. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Looks like it's the cctests not locking threads and the exposure kinda spreads once someone is locking the threads. The second commits fix them locally for me. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@nodejs/cpp-reviewers |
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## main #57031 +/- ##
=======================================
Coverage 89.11% 89.11%
=======================================
Files 665 665
Lines 193193 193194 +1
Branches 37212 37212
=======================================
+ Hits 172158 172168 +10
+ Misses 13775 13774 -1
+ Partials 7260 7252 -8
|
Sorry, something went wrong.
anonrig
approved these changes
Feb 13, 2025
addaleax
approved these changes
Feb 14, 2025
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jasnell
approved these changes
Feb 15, 2025
RafaelGSS
approved these changes
Feb 15, 2025
targos
pushed a commit
that referenced
this pull request
Feb 17, 2025
Otherwise it may fail the DCHECK that uses the locked thread as a fast path to get the current thread. PR-URL: #57031 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
acidiney
pushed a commit
to acidiney/node
that referenced
this pull request
Feb 23, 2025
Otherwise it may fail the DCHECK that uses the locked thread as a fast path to get the current thread. PR-URL: nodejs#57031 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
aduh95
pushed a commit
that referenced
this pull request
Apr 2, 2025
Otherwise it may fail the DCHECK that uses the locked thread as a fast path to get the current thread. PR-URL: #57031 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
aduh95
pushed a commit
that referenced
this pull request
Apr 3, 2025
Otherwise it may fail the DCHECK that uses the locked thread as a fast path to get the current thread. PR-URL: #57031 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 16, 2025
Otherwise it may fail the DCHECK that uses the locked thread as a fast path to get the current thread. PR-URL: #57031 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 17, 2025
Otherwise it may fail the DCHECK that uses the locked thread as a fast path to get the current thread. PR-URL: #57031 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
codebytere
added a commit
to electron/electron
that referenced
this pull request
Apr 25, 2025
codebytere
added a commit
to electron/electron
that referenced
this pull request
Apr 25, 2025
codebytere
added a commit
to electron/electron
that referenced
this pull request
May 1, 2025
codebytere
added a commit
to electron/electron
that referenced
this pull request
May 5, 2025
* chore: bump node in DEPS to v22.15.0 * inspector: fix GN build nodejs/node#56798 * test: search cctest files nodejs/node#56791 * crypto: fix missing OPENSSL_NO_ENGINE guard nodejs/node#57012 * test,crypto: make tests work for BoringSSL nodejs/node#57021 * module: use synchronous hooks for preparsing in import(cjs) nodejs/node#55698 * deps: update simdjson to 3.12.0 nodejs/node#56874 * build: remove explicit linker call to libm on macOS nodejs/node#56901 * test: make eval snapshot comparison more flexible nodejs/node#57020 * src: allow embedder customization of OOMErrorHandler nodejs/node#57325 * src: do not pass nullptr to std::string ctor nodejs/node#57354 * src: lock the isolate properly in IsolateData destructor nodejs/node#57031 * chore: shrink --trace-atomics-wait patch * chore: fixup patch indices * build: fix GN build failure nodejs/node#57013 * crypto: expose security levels nodejs/node#56601 * zlib: add zstd support nodejs/node#52100 * test: move crypto related common utilities in common/crypto nodejs/node#56714 * cli: move --trace-atomics-wait to eol nodejs/node#52747 * test: disable test-https-client-renegotiation-limit BoringSSL doesn't support caller-initiated renegotiation - see https://source.chromium.org/chromium/chromium/src/+/main:third_party/boringssl/src/ssl/ssl_lib.cc;l=1627-1631 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
codebytere
added a commit
to electron/electron
that referenced
this pull request
May 5, 2025
codebytere
added a commit
to electron/electron
that referenced
this pull request
May 6, 2025
codebytere
added a commit
to electron/electron
that referenced
this pull request
May 6, 2025
* chore: bump node in DEPS to v22.15.0 * inspector: fix GN build nodejs/node#56798 * test: search cctest files nodejs/node#56791 * crypto: fix missing OPENSSL_NO_ENGINE guard nodejs/node#57012 * test,crypto: make tests work for BoringSSL nodejs/node#57021 * module: use synchronous hooks for preparsing in import(cjs) nodejs/node#55698 * deps: update simdjson to 3.12.0 nodejs/node#56874 * build: remove explicit linker call to libm on macOS nodejs/node#56901 * test: make eval snapshot comparison more flexible nodejs/node#57020 * src: allow embedder customization of OOMErrorHandler nodejs/node#57325 * src: do not pass nullptr to std::string ctor nodejs/node#57354 * src: lock the isolate properly in IsolateData destructor nodejs/node#57031 * chore: shrink --trace-atomics-wait patch * chore: fixup patch indices * build: fix GN build failure nodejs/node#57013 * crypto: expose security levels nodejs/node#56601 * zlib: add zstd support nodejs/node#52100 * test: move crypto related common utilities in common/crypto nodejs/node#56714 * cli: move --trace-atomics-wait to eol nodejs/node#52747 * test: disable test-https-client-renegotiation-limit BoringSSL doesn't support caller-initiated renegotiation - see https://source.chromium.org/chromium/chromium/src/+/main:third_party/boringssl/src/ssl/ssl_lib.cc;l=1627-1631 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
kigh-ota
pushed a commit
to kigh-ota/electron
that referenced
this pull request
Sep 30, 2025
* chore: bump node in DEPS to v22.15.0 * inspector: fix GN build nodejs/node#56798 * test: search cctest files nodejs/node#56791 * crypto: fix missing OPENSSL_NO_ENGINE guard nodejs/node#57012 * test,crypto: make tests work for BoringSSL nodejs/node#57021 * module: use synchronous hooks for preparsing in import(cjs) nodejs/node#55698 * deps: update simdjson to 3.12.0 nodejs/node#56874 * build: remove explicit linker call to libm on macOS nodejs/node#56901 * test: make eval snapshot comparison more flexible nodejs/node#57020 * src: allow embedder customization of OOMErrorHandler nodejs/node#57325 * src: do not pass nullptr to std::string ctor nodejs/node#57354 * src: lock the isolate properly in IsolateData destructor nodejs/node#57031 * chore: shrink --trace-atomics-wait patch * chore: fixup patch indices * build: fix GN build failure nodejs/node#57013 * crypto: expose security levels nodejs/node#56601 * zlib: add zstd support nodejs/node#52100 * test: move crypto related common utilities in common/crypto nodejs/node#56714 * cli: move --trace-atomics-wait to eol nodejs/node#52747 * test: disable test-https-client-renegotiation-limit BoringSSL doesn't support caller-initiated renegotiation - see https://source.chromium.org/chromium/chromium/src/+/main:third_party/boringssl/src/ssl/ssl_lib.cc;l=1627-1631 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise it may fail the DCHECK that uses the locked thread as a fast path to get the current thread.