Review requested:

• @nodejs/loaders

CI: https://ci.nodejs.org/job/node-test-pull-request/65306/

The diff here is suspiciously HUGE. Are you sure this is correct?

What do you mean by huge? It doesn't appear to be much bigger than the PRs (note that the first PR #55698 has already 2000+ lines added due to the amount of tests added)

CI: https://ci.nodejs.org/job/node-test-pull-request/65507/

CI: https://ci.nodejs.org/job/node-test-pull-request/65544/

CI: https://ci.nodejs.org/job/node-test-pull-request/65589/

CI: https://ci.nodejs.org/job/node-test-pull-request/65607/

CI: https://ci.nodejs.org/job/node-test-pull-request/65613/

The only remaining failure seems to be a flake that already exists on the v22.x-staging branch.

15:09:01 not ok 306 parallel/test-fs-cp
15:09:01   ---
15:09:01   duration_ms: 666.01900
15:09:01   severity: fail
15:09:01   exitcode: 1
15:09:01   stack: |-
15:09:01     node:assert:128
15:09:01       throw new AssertionError(obj);
15:09:01       ^
15:09:01     
15:09:01     AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
15:09:01     + actual - expected
15:09:01     
15:09:01     + 'ERR_FS_EISDIR'
15:09:01     - 'ERR_FS_CP_EINVAL'
15:09:01               ^
15:09:01     
15:09:01         at file:///c:/workspace/node-test-binary-windows-js-suites/node/test/parallel/test-fs-cp.mjs:687:12
15:09:01         at c:\workspace\node-test-binary-windows-js-suites\node\test\common\index.js:435:15
15:09:01         at node:fs:188:23
15:09:01         at callbackifyOnRejected (node:util:374:10)
15:09:01         at process.processTicksAndRejections (node:internal/process/task_queues:90:21) {
15:09:01       generatedMessage: true,
15:09:01       code: 'ERR_ASSERTION',
15:09:01       actual: 'ERR_FS_EISDIR',
15:09:01       expected: 'ERR_FS_CP_EINVAL',
15:09:01       operator: 'strictEqual'
15:09:01     }
15:09:01     
15:09:01     Node.js v22.14.1-pre
15:09:01   ...

See https://ci.nodejs.org/job/node-test-binary-windows-js-suites/33054/RUN_SUBSET=2,nodes=win11-COMPILED_BY-vs2022/testReport/junit/(root)/parallel/test_fs_cp/ from the node-daily-v22.x-staging job today which has the same failure.

Should this be merged considering the test failure already exists on v22.x-staging? @nodejs/releasers

(It may be a pretty bad flake, I am seeing that v22.x-staging has been almost red for most days in the past month now: https://ci.nodejs.org/view/Node.js%20Daily/job/node-daily-v22.x-staging/)

This test is already marked flaky on main in 304bb9c.

As seen from this comment the fix for this already exists in libuv and will make its way into Node at some point. Until then, it would probably make sense to backport the commit mentioned above in all LTS branches.

As seen from this comment the fix for this already exists in libuv and will make its way into Node at some point. Until then, it would probably make sense to backport the commit mentioned above in all LTS branches.

@StefanStojanovic FWIW libuv updates in Node.js 22 (and presumably earlier release lines) are blocked on CI failures on 32-bit Windows: #57316

Hi @joyeecheung, just a FYI, I'll issue a v22 release soon this week, and this PR might not go due to red-CI.

@RafaelGSS The last time the CI was run #57130 (comment) the failures were the same failures already failing v22.x-staging. If v22.x-staging is green then this should be green. Though I don't know if it's necessary to restart a CI to check again.

Ok, I can land it on v22.x-staging and we can check on proposal if an error pops-up related to this PR (which is unlikely)

Landed in a68f127...926b887