FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: fix crash when lazy getter is invoked in a vm context by legendecas · Pull Request #57168 · nodejs/node · GitHub

/ node Public

src: fix crash when lazy getter is invoked in a vm context - #57168

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
legendecas:realm/creation-in-lazy-getter
Feb 23, 2025
ConversationCommits (1)ChecksFiles changed
Merged

src: fix crash when lazy getter is invoked in a vm context#57168
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
legendecas:realm/creation-in-lazy-getter

Conversation

legendecas commented Feb 21, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

V8 should invoke native functions in their creation context,
preventing dynamic context by the caller. However, the lazy getter has
no JavaScript function representation and has no creation context. It
is not invoked in the original creation context. Fix the null realm by
retrieving the creation context via this argument.

Fixes #57166

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. labels Feb 21, 2025
legendecas force-pushed the realm/creation-in-lazy-getter branch from d2261c9 to bc86e5e Compare February 21, 2025 15:24
src: fix crash when lazy getter is invoked in a vm context
cf2e520 
V8 should invoke native functions in their creation context,
preventing dynamic context by the caller. However, the lazy getter has
no JavaScript function representation and has no creation context. It
is not invoked in the original creation context. Fix the null realm by
retrieving the creation context via `this` argument.
legendecas force-pushed the realm/creation-in-lazy-getter branch from bc86e5e to cf2e520 Compare February 21, 2025 15:29

targos commented Feb 21, 2025

Copy link
Copy Markdown
Member

@nodejs/cpp-reviewers

codecov Bot commented Feb 21, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 45.45455% with 6 lines in your changes missing coverage. Please review.

Project coverage is 90.35%. Comparing base (8fc919d) to head (cf2e520).
Report is 106 commits behind head on main.

Files with missing lines Patch % Lines
src/node_util.cc 45.45% 4 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #57168      +/-   ##
==========================================
- Coverage   90.35%   90.35%   -0.01%     
==========================================
  Files         629      629              
  Lines      184308   184373      +65     
  Branches    36015    36019       +4     
==========================================
+ Hits       166532   166584      +52     
- Misses      10909    10916       +7     
- Partials     6867     6873       +6
Files with missing lines Coverage Δ
src/node_errors.h 85.29% <ø> (ø)
src/node_util.cc 82.18% <45.45%> (-1.47%) ⬇️

... and 26 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 21, 2025
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 21, 2025

nodejs-github-bot commented Feb 21, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65364/

nodejs-github-bot commented Feb 23, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65381/

targos commented Feb 23, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

citgm check: https://ci.nodejs.org/job/citgm-smoker/nodes=ubuntu2204-64/3560/
https://ci.nodejs.org/job/citgm-smoker/nodes=ubuntu2204-64/3560/testReport/(root)/citgm/commander_v13_1_0/ ✅

aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 23, 2025
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 23, 2025
nodejs-github-bot merged commit 4e1f0cc into nodejs:main Feb 23, 2025

nodejs-github-bot commented Feb 23, 2025

Copy link
Copy Markdown
Collaborator

Landed in 4e1f0cc

acidiney pushed a commit to acidiney/node that referenced this pull request Feb 23, 2025
src: fix crash when lazy getter is invoked in a vm context
1930ad1 
V8 should invoke native functions in their creation context,
preventing dynamic context by the caller. However, the lazy getter has
no JavaScript function representation and has no creation context. It
is not invoked in the original creation context. Fix the null realm by
retrieving the creation context via `this` argument.

PR-URL: nodejs#57168
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
legendecas deleted the realm/creation-in-lazy-getter branch February 23, 2025 22:23
targos pushed a commit that referenced this pull request Feb 24, 2025
src: fix crash when lazy getter is invoked in a vm context
4564456 
V8 should invoke native functions in their creation context,
preventing dynamic context by the caller. However, the lazy getter has
no JavaScript function representation and has no creation context. It
is not invoked in the original creation context. Fix the null realm by
retrieving the creation context via `this` argument.

PR-URL: #57168
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
github-actions Bot mentioned this pull request Feb 25, 2025
Merged
targos pushed a commit that referenced this pull request Feb 25, 2025
src: fix crash when lazy getter is invoked in a vm context
ef314dc 
V8 should invoke native functions in their creation context,
preventing dynamic context by the caller. However, the lazy getter has
no JavaScript function representation and has no creation context. It
is not invoked in the original creation context. Fix the null realm by
retrieving the creation context via `this` argument.

PR-URL: #57168
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 1, 2025
src: fix crash when lazy getter is invoked in a vm context
e2635d8 
V8 should invoke native functions in their creation context,
preventing dynamic context by the caller. However, the lazy getter has
no JavaScript function representation and has no creation context. It
is not invoked in the original creation context. Fix the null realm by
retrieving the creation context via `this` argument.

PR-URL: #57168
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request Apr 2, 2025
src: fix crash when lazy getter is invoked in a vm context
86dcb53 
V8 should invoke native functions in their creation context,
preventing dynamic context by the caller. However, the lazy getter has
no JavaScript function representation and has no creation context. It
is not invoked in the original creation context. Fix the null realm by
retrieving the creation context via `this` argument.

PR-URL: #57168
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request Apr 3, 2025
src: fix crash when lazy getter is invoked in a vm context
9bc30db 
V8 should invoke native functions in their creation context,
preventing dynamic context by the caller. However, the lazy getter has
no JavaScript function representation and has no creation context. It
is not invoked in the original creation context. Fix the null realm by
retrieving the creation context via `this` argument.

PR-URL: #57168
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 mentioned this pull request Apr 11, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 16, 2025
src: fix crash when lazy getter is invoked in a vm context
838646e 
V8 should invoke native functions in their creation context,
preventing dynamic context by the caller. However, the lazy getter has
no JavaScript function representation and has no creation context. It
is not invoked in the original creation context. Fix the null realm by
retrieving the creation context via `this` argument.

PR-URL: #57168
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 17, 2025
src: fix crash when lazy getter is invoked in a vm context
e323694 
V8 should invoke native functions in their creation context,
preventing dynamic context by the caller. However, the lazy getter has
no JavaScript function representation and has no creation context. It
is not invoked in the original creation context. Fix the null realm by
retrieving the creation context via `this` argument.

PR-URL: #57168
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
src: fix crash when lazy getter is invoked in a vm context
86584f7 
V8 should invoke native functions in their creation context,
preventing dynamic context by the caller. However, the lazy getter has
no JavaScript function representation and has no creation context. It
is not invoked in the original creation context. Fix the null realm by
retrieving the creation context via `this` argument.

PR-URL: #57168
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
src: fix crash when lazy getter is invoked in a vm context
8c9b5cf 
V8 should invoke native functions in their creation context,
preventing dynamic context by the caller. However, the lazy getter has
no JavaScript function representation and has no creation context. It
is not invoked in the original creation context. Fix the null realm by
retrieving the creation context via `this` argument.

PR-URL: #57168
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
addaleax addaleax approved these changes
anonrig anonrig approved these changes
aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Segmentation fault in Jest

7 participants

Back | FazBrowse Home | New Git URL