src: set default config as node.config.json by marco-ippolito · Pull Request #57171 · nodejs/node · GitHub

This PR changes the current behavior:

node --experimental-default-config-file foo.js

Will automatically look for a node.config.json file (I dont have strong opinion on the default)

If a --experimental-config-file is provided it will use that:

node --experimental-config-file=foo.json foo.js

Hmm, I'm a bit concerned about naming collisions with existing uses of node.json such as this https://github.com/kubeedge/kubeedge/blob/master/build/node.json.

Maybe noderc.json? That should not have collisions (I HOPE 😆)

In any case, I don't think it should be unflagged from the first release.

In any case, I don't think it should be unflagged from the first release.

it's not unflagged, I'm not sure what are you referring to

Okay then, I guess I didn't read the commit message correctly

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 90.26%. Comparing base (044d69a) to head (e38690d).
Report is 542 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_config_file.cc	63.63%	2 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #57171      +/-   ##
==========================================
- Coverage   90.35%   90.26%   -0.09%     
==========================================
  Files         629      630       +1     
  Lines      184424   184643     +219     
  Branches    36034    36135     +101     
==========================================
+ Hits       166633   166673      +40     
- Misses      10913    11024     +111     
- Partials     6878     6946      +68

Files with missing lines	Coverage Δ
lib/internal/process/pre_execution.js	93.03% <100.00%> (-0.28%)	⬇️
src/node_options.cc	85.34% <100.00%> (+0.01%)	⬆️
src/node_options.h	98.33% <100.00%> (+<0.01%)	⬆️
src/node_config_file.cc	73.18% <63.63%> (+1.21%)	⬆️

... and 41 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

When searching I was only able to find examples of node.json in common use. Even nodejs.json might work (despite the ugly double js in there). Or .node.json (making it a dot prefixed file). The other possibility is that we look for a .nodejs directory in cwd and load .nodejs/config.json. Every option is likely equally unfortunate in their own special ways tho.

Best options are
.node.json or
noderc.json imho, I'll try a survey on social media so see what people think

How does this play with file permissions?

How does this play with file permissions?

I added a test, also will need a rebase after #57170 lands.

There are 6k results for node.json on github:
https://github.com/search?q=path:**/node.json+language:JSON&type=code&l=JSON

I wish we could just take it 🥺

Otherwise:

node.config.json
nodejs.json

Modern versions of eslint and prettier both support a version of .config naming notion such as eslint.config.cjs, so node.config.json would align nicely, and having .config in the name makes it pretty obvious and explicit.

IMO, node.config.json to de moon 🚀🌔

node.config.json it is

This commit didn't land cleanly on v22.x-staging. It requires a manual backport, so I'm adding a backport-requested label.

PR-URL: #57171 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

Notable changes: config: * (SEMVER-MINOR) add config file support (Marco Ippolito) #57016 * (SEMVER-MINOR) set default config as `node.config.json` (Marco Ippolito) #57171 crypto: * update root certificates to NSS 3.108 (Node.js GitHub Bot) #57381 doc: * add geeksilva97 to collaborators (Edy Silva) #57241 src: * (SEMVER-MINOR) create `THROW_ERR_OPTIONS_BEFORE_BOOTSTRAPPING` (Marco Ippolito) #57016 test_runner: * (SEMVER-MINOR) change ts default glob (Marco Ippolito) #57359 tls: * (SEMVER-MINOR) implement `tls.getCACertificates()` (Joyee Cheung) #57107 v8: * (SEMVER-MINOR) add `v8.getCppHeapStatistics()` method (Aditi) #57146 PR-URL: #57424

PR-URL: #57171 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

Notable changes: config: * (SEMVER-MINOR) add config file support (Marco Ippolito) #57016 * (SEMVER-MINOR) set default config as `node.config.json` (Marco Ippolito) #57171 crypto: * update root certificates to NSS 3.108 (Node.js GitHub Bot) #57381 doc: * add geeksilva97 to collaborators (Edy Silva) #57241 src: * (SEMVER-MINOR) create `THROW_ERR_OPTIONS_BEFORE_BOOTSTRAPPING` (Marco Ippolito) #57016 test_runner: * (SEMVER-MINOR) change ts default glob (Marco Ippolito) #57359 tls: * (SEMVER-MINOR) implement `tls.getCACertificates()` (Joyee Cheung) #57107 v8: * (SEMVER-MINOR) add `v8.getCppHeapStatistics()` method (Aditi) #57146 PR-URL: #57424

PR-URL: nodejs#57171 Backport-PR-URL: nodejs#57958 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

PR-URL: #57171 Backport-PR-URL: #57958 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

Notable changes: deps: * update timezone to 2025b (Node.js GitHub Bot) #57857 doc: * add dario-piotrowicz to collaborators (Dario Piotrowicz) #58102 * (SEMVER-MINOR) graduate multiple experimental apis (James M Snell) #57765 esm: * (SEMVER-MINOR) graduate import.meta properties (James M Snell) #58011 * (SEMVER-MINOR) support top-level Wasm without package type (Guy Bedford) #57610 sqlite: * (SEMVER-MINOR) add StatementSync.prototype.columns() (Colin Ihrig) #57490 src: * (SEMVER-MINOR) set default config as `node.config.json` (Marco Ippolito) #57171 * (SEMVER-MINOR) create `THROW_ERR_OPTIONS_BEFORE_BOOTSTRAPPING` (Marco Ippolito) #57016 * (SEMVER-MINOR) add config file support (Marco Ippolito) #57016 * (SEMVER-MINOR) add ExecutionAsyncId getter for any Context (Attila Szegedi) #57820 stream: * (SEMVER-MINOR) preserve AsyncLocalStorage context in finished() (Gürgün Dayıoğlu) #57865 util: * (SEMVER-MINOR) add `types.isFloat16Array()` (Livia Medeiros) #57879 worker: * (SEMVER-MINOR) add worker.getHeapStatistics() (Matteo Collina) #57888 PR-URL: #58388

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Feb 21, 2025

marco-ippolito added the semver-minor PRs that contain new features and should be released in the next minor version. label Feb 21, 2025

marco-ippolito mentioned this pull request Feb 21, 2025

src: namespace config file flags #57170

Closed

anonrig reviewed Feb 22, 2025

View reviewed changes

marco-ippolito marked this pull request as draft February 24, 2025 11:40

marco-ippolito force-pushed the default-value-node-json branch from f1b6d67 to 70b3289 Compare February 24, 2025 12:02

marco-ippolito changed the title src: set default config as node.json src: set default config as node.config.json Feb 24, 2025

marco-ippolito force-pushed the default-value-node-json branch from 70b3289 to e00ade9 Compare February 24, 2025 12:03

marco-ippolito marked this pull request as ready for review February 24, 2025 12:05

marco-ippolito force-pushed the default-value-node-json branch 3 times, most recently from c0373f2 to 6456729 Compare February 24, 2025 12:16

marco-ippolito requested review from anonrig and jasnell February 24, 2025 13:16

GeoffreyBooth reviewed Feb 24, 2025

View reviewed changes

Comment thread doc/api/cli.md Outdated

marco-ippolito force-pushed the default-value-node-json branch 2 times, most recently from 434360e to 54b272c Compare February 25, 2025 06:03

RafaelGSS added the backport-requested-v22.x PRs awaiting manual backport to the v22.x-staging branch. label Apr 11, 2025

marco-ippolito added the backport-open-v22.x Indicate that the PR has an open backport label Apr 21, 2025

RafaelGSS pushed a commit that referenced this pull request May 1, 2025

src: set default config as node.config.json

19ca669

PR-URL: #57171 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

RafaelGSS pushed a commit that referenced this pull request May 2, 2025

src: set default config as node.config.json

6d9e998

PR-URL: #57171 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

aduh95 mentioned this pull request May 6, 2025

[v22.x backport] src: add config file support #57958

Merged

aduh95 pushed a commit to marco-ippolito/node that referenced this pull request May 6, 2025

src: set default config as node.config.json

64a157f

PR-URL: nodejs#57171 Backport-PR-URL: nodejs#57958 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

aduh95 added backported-to-v22.x PRs backported to the v22.x-staging branch. and removed backport-open-v22.x Indicate that the PR has an open backport backport-requested-v22.x PRs awaiting manual backport to the v22.x-staging branch. labels May 6, 2025

aduh95 pushed a commit that referenced this pull request May 6, 2025

src: set default config as node.config.json

8e58fbe

PR-URL: #57171 Backport-PR-URL: #57958 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

RafaelGSS pushed a commit that referenced this pull request May 14, 2025

src: set default config as node.config.json

914a4d5

PR-URL: #57171 Backport-PR-URL: #57958 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

aduh95 pushed a commit that referenced this pull request May 16, 2025

src: set default config as node.config.json

e004de5

PR-URL: #57171 Backport-PR-URL: #57958 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

aduh95 pushed a commit that referenced this pull request May 17, 2025

src: set default config as node.config.json

a7e7b7e

PR-URL: #57171 Backport-PR-URL: #57958 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

aduh95 pushed a commit that referenced this pull request May 18, 2025

src: set default config as node.config.json

e85580d

PR-URL: #57171 Backport-PR-URL: #57958 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

github-actions Bot mentioned this pull request May 19, 2025

2025-05-21, Version 22.16.0 'Jod' (LTS) #58388

Merged

aduh95 pushed a commit that referenced this pull request May 19, 2025

src: set default config as node.config.json

5d1230b

PR-URL: #57171 Backport-PR-URL: #57958 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

codebytere mentioned this pull request May 26, 2025

chore: bump node to v22.16.0 (main) electron/electron#47217

Merged

ghost mentioned this pull request Jun 8, 2025

### Notable Changes autofix-ci/action#28

Closed

src: set default config as node.config.json by marco-ippolito · Pull Request #57171 · nodejs/node · GitHub

Uh oh!

Uh oh!

src: set default config as node.config.json - #57171

src: set default config as node.config.json#57171nodejs-github-bot merged 1 commit intonodejs:mainnodejs/node:mainfrom marco-ippolito:default-value-node-jsonmarco-ippolito/node:default-value-node-jsonCopy head branch name to clipboard

Conversation

marco-ippolito commented Feb 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jasnell commented Feb 21, 2025

Uh oh!

marco-ippolito commented Feb 21, 2025

Uh oh!

targos commented Feb 21, 2025

Uh oh!

marco-ippolito commented Feb 21, 2025

Uh oh!

targos commented Feb 21, 2025

Uh oh!

codecov Bot commented Feb 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

jasnell commented Feb 21, 2025

Uh oh!

marco-ippolito commented Feb 21, 2025

Uh oh!

anonrig left a comment

Choose a reason for hiding this comment

Uh oh!

marco-ippolito commented Feb 22, 2025

Uh oh!

darcyrush commented Feb 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bricss commented Feb 24, 2025

Uh oh!

marco-ippolito commented Feb 24, 2025

Uh oh!

Uh oh!

RafaelGSS commented Apr 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

src: set default config as node.config.json#57171
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
marco-ippolito:default-value-node-json

marco-ippolito commented Feb 21, 2025 •
edited
Loading

codecov Bot commented Feb 21, 2025 •
edited
Loading

darcyrush commented Feb 24, 2025 •
edited
Loading