| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
Fixes nodejs#57206 Added restart log in test-runner/runner.js to log with timestamp and test-file, whenever the test file is restart testing in `--watch` mode.
|
Review requested:
|
Sorry, something went wrong.
|
Hey @sivakumar-77, thanks for opening this PR! 🚀 I think we should avoid adding process.stdout.write directly inside the runner restart logic. I would suggest adding a new event, like the existing one, test:watch:drained, to allow users to customise the behaviour while avoiding unwanted output in existing custom reporters. Could you also please add tests to cover this feature? |
Sorry, something went wrong.
|
Hey @pmarchini thanks for the feedback! 🙌 That makes sense—I’ll update the PR to introduce a new event instead of directly modifying the runner restart logic. I’ll also update the internal reporters to handle it appropriately. I'll add tests to cover this feature as well. Thanks |
Sorry, something went wrong.
|
@pmarchini I've taken over this piece of work here #57903 |
Sorry, something went wrong.
|
Hey @sivakumar-77, as this PR seems stale, shall we close it, or are you still working on it? |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Fixes #57206
Added restart log in test-runner/runner.js to log with timestamp and test-file
whenever the test file is restart testing in --watch mode.