src: add a variant of ToV8Value() - #57576
Closed
Aditi-1400 wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Aditi-1400
force-pushed
the
primitive-array
branch
2 times, most recently
from
565d8b1 to
fc7eafe
Compare
March 21, 2025 14:09
jasnell
reviewed
Mar 21, 2025
Comment thread
src/util-inl.h
Outdated
jasnell
reviewed
Mar 21, 2025
Comment thread
src/util-inl.h
Outdated
jasnell
reviewed
Mar 21, 2025
Comment thread
src/util-inl.h
Outdated
Copy link
Copy Markdown
Codecov ReportAttention: Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.
@@ Coverage Diff @@
## main #57576 +/- ##
========================================
Coverage 90.23% 90.24%
========================================
Files 629 630 +1
Lines 184939 185080 +141
Branches 36232 36229 -3
========================================
+ Hits 166885 167020 +135
- Misses 11011 11031 +20
+ Partials 7043 7029 -14
... and 73 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
anonrig
requested changes
Mar 21, 2025
anonrig
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
This is not a better replacement than what we have right now, and lacks real world usage. We shouldn't introduce new functions that we don't use at all.
Sorry, something went wrong.
Adds a variant of ToV8Value for array of primitives that do not need to throw during conversion - there is essentially no exceptions that can be thrown then an array of integers is created.
Aditi-1400
force-pushed
the
primitive-array
branch
from
fc7eafe to
d037058
Compare
April 2, 2025 20:04
jasnell
approved these changes
Apr 5, 2025
This comment was marked as outdated.
joyeecheung
approved these changes
Apr 10, 2025
This comment was marked as outdated.
Copy link
Copy Markdown
Member
|
@anonrig Are you still blocking the PR? It's updated significantly and the helper is being used in a function. |
Sorry, something went wrong.
anonrig
approved these changes
Apr 16, 2025
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as duplicate.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jasnell
pushed a commit
that referenced
this pull request
May 12, 2025
Adds a variant of ToV8Value for array of primitives that do not need to throw during conversion - there is essentially no exceptions that can be thrown then an array of integers is created. PR-URL: #57576 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 16, 2025
Adds a variant of ToV8Value for array of primitives that do not need to throw during conversion - there is essentially no exceptions that can be thrown then an array of integers is created. PR-URL: #57576 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Jun 10, 2025
Adds a variant of ToV8Value for array of primitives that do not need to throw during conversion - there is essentially no exceptions that can be thrown then an array of integers is created. PR-URL: #57576 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a variant of ToV8Value for array of primitives that do not need to throw during conversion - there is essentially no exceptions that can be thrown then you create an array of integers and you are only dealing with the one-size-fit-all abstraction of ToV8Value.