FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update std::vector<v8::Local<T>> to use v8::LocalVector<T> (Part 2) by Aditi-1400 · Pull Request #57642 · nodejs/node · GitHub

/ node Public

Update std::vector<v8::Local<T>> to use v8::LocalVector<T> (Part 2) - #57642

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Aditi-1400:contextify-vector-replace
Apr 16, 2025
ConversationCommits (1)ChecksFiles changed
Merged

Update std::vector<v8::Local<T>> to use v8::LocalVector<T> (Part 2)#57642
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Aditi-1400:contextify-vector-replace

Conversation

Aditi-1400 commented Mar 26, 2025

Copy link
Copy Markdown
Contributor

A follow up of #57578 to replace all std::vector<v8::Local<T>> to use v8::LocalVector<T>

Also updates src/README.md to document the same.

nodejs-github-bot commented Mar 26, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/single-executable
  • @nodejs/startup

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Mar 26, 2025
Aditi-1400 force-pushed the contextify-vector-replace branch from d0175c7 to 30d022e Compare March 26, 2025 18:45
Aditi-1400 changed the title src: update std::vector<v8::Local<T>> to use v8::LocalVector<T> Update std::vector<v8::Local<T>> to use v8::LocalVector<T> (Part 2) Mar 26, 2025
Aditi-1400 force-pushed the contextify-vector-replace branch from 30d022e to 2581400 Compare March 26, 2025 18:52

codecov Bot commented Mar 26, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.24%. Comparing base (1123585) to head (54ff50f).
Report is 146 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #57642      +/-   ##
==========================================
+ Coverage   90.22%   90.24%   +0.01%     
==========================================
  Files         630      630              
  Lines      185055   185081      +26     
  Branches    36216    36228      +12     
==========================================
+ Hits       166975   167020      +45     
+ Misses      11042    11030      -12     
+ Partials     7038     7031       -7
Files with missing lines Coverage Δ
src/node_contextify.cc 80.47% <100.00%> (-0.04%) ⬇️
src/node_contextify.h 86.66% <ø> (+6.66%) ⬆️
src/node_sea.cc 91.30% <100.00%> (+0.04%) ⬆️
src/node_snapshotable.cc 75.43% <100.00%> (+0.05%) ⬆️

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

legendecas reviewed Mar 27, 2025
View reviewed changes
Comment thread src/README.md Outdated
Aditi-1400 force-pushed the contextify-vector-replace branch from 2581400 to 44691fc Compare March 27, 2025 16:35
joyeecheung approved these changes Mar 27, 2025
View reviewed changes
Comment thread src/README.md Outdated

joyeecheung Mar 27, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Now come to think of it, when it's done we can probably add a rule to cpplint.py to just disallow std::vector<Local> or std::vector<v8::Local> (should be pretty straight-forward to implement).

jasnell reviewed Mar 27, 2025
View reviewed changes
Comment thread src/README.md Outdated
src: update std::vector<v8::Local<T>> to use v8::LocalVector<T>
54ff50f 
A follow up of nodejs#57578 to
replace all std::vector<v8::Local<T>> to use v8::LocalVector<T>
Aditi-1400 force-pushed the contextify-vector-replace branch from 44691fc to 54ff50f Compare April 2, 2025 21:34

nodejs-github-bot commented Apr 5, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66046/

joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 10, 2025
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 10, 2025

nodejs-github-bot commented Apr 10, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66189/

nodejs-github-bot commented Apr 16, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66306/

joyeecheung added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 16, 2025
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 16, 2025
nodejs-github-bot merged commit ad3e835 into nodejs:main Apr 16, 2025

nodejs-github-bot commented Apr 16, 2025

Copy link
Copy Markdown
Collaborator

Landed in ad3e835

RafaelGSS pushed a commit that referenced this pull request May 1, 2025
src: update std::vector<v8::Local<T>> to use v8::LocalVector<T>
18735df 
A follow up of #57578 to
replace all std::vector<v8::Local<T>> to use v8::LocalVector<T>

PR-URL: #57642
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
src: update std::vector<v8::Local<T>> to use v8::LocalVector<T>
4e7ae97 
A follow up of #57578 to
replace all std::vector<v8::Local<T>> to use v8::LocalVector<T>

PR-URL: #57642
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request May 6, 2025
src: update std::vector<v8::Local<T>> to use v8::LocalVector<T>
a054817 
A follow up of #57578 to
replace all std::vector<v8::Local<T>> to use v8::LocalVector<T>

PR-URL: #57642
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request May 6, 2025
src: update std::vector<v8::Local<T>> to use v8::LocalVector<T>
e3a939f 
A follow up of #57578 to
replace all std::vector<v8::Local<T>> to use v8::LocalVector<T>

PR-URL: #57642
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
src: update std::vector<v8::Local<T>> to use v8::LocalVector<T>
5c852e1 
A follow up of #57578 to
replace all std::vector<v8::Local<T>> to use v8::LocalVector<T>

PR-URL: #57642
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request May 16, 2025
src: update std::vector<v8::Local<T>> to use v8::LocalVector<T>
b2fa319 
A follow up of #57578 to
replace all std::vector<v8::Local<T>> to use v8::LocalVector<T>

PR-URL: #57642
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request May 17, 2025
src: update std::vector<v8::Local<T>> to use v8::LocalVector<T>
2e34fc2 
A follow up of #57578 to
replace all std::vector<v8::Local<T>> to use v8::LocalVector<T>

PR-URL: #57642
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request May 18, 2025
src: update std::vector<v8::Local<T>> to use v8::LocalVector<T>
fca38f7 
A follow up of #57578 to
replace all std::vector<v8::Local<T>> to use v8::LocalVector<T>

PR-URL: #57642
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
github-actions Bot mentioned this pull request May 19, 2025
Merged
aduh95 pushed a commit that referenced this pull request May 19, 2025
src: update std::vector<v8::Local<T>> to use v8::LocalVector<T>
0f2cbc1 
A follow up of #57578 to
replace all std::vector<v8::Local<T>> to use v8::LocalVector<T>

PR-URL: #57642
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
ghost mentioned this pull request Jun 8, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Qard Qard approved these changes
jasnell jasnell approved these changes
anonrig anonrig approved these changes
joyeecheung joyeecheung approved these changes
legendecas legendecas approved these changes
RaisinTen RaisinTen approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL