FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update std::vector<v8::Local<T>> to use v8::LocalVector<T> (Part 3) by Aditi-1400 · Pull Request #57646 · nodejs/node · GitHub

/ node Public

Update std::vector<v8::Local<T>> to use v8::LocalVector<T> (Part 3) - #57646

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Aditi-1400:replace-vector-2
Apr 16, 2025
ConversationCommits (1)ChecksFiles changed
Merged

Update std::vector<v8::Local<T>> to use v8::LocalVector<T> (Part 3)#57646
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Aditi-1400:replace-vector-2

Conversation

Aditi-1400 commented Mar 27, 2025

Copy link
Copy Markdown
Contributor

A follow up of #57578 to replace all std::vector<v8::Local> to use v8::LocalVector

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Mar 27, 2025

codecov Bot commented Mar 27, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.23%. Comparing base (1123585) to head (bacda14).
Report is 146 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #57646   +/-   ##
=======================================
  Coverage   90.22%   90.23%           
=======================================
  Files         630      630           
  Lines      185055   185057    +2     
  Branches    36216    36224    +8     
=======================================
+ Hits       166975   166978    +3     
+ Misses      11042    11036    -6     
- Partials     7038     7043    +5
Files with missing lines Coverage Δ
src/node_process_methods.cc 87.85% <100.00%> (+0.05%) ⬆️

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

legendecas reviewed Mar 27, 2025
View reviewed changes
Comment thread src/node_process_methods.cc Outdated
Comment thread src/node_process_methods.cc Outdated
joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 10, 2025
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 10, 2025

nodejs-github-bot commented Apr 10, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66188/

nodejs-github-bot commented Apr 16, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66305/

joyeecheung added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 16, 2025
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 16, 2025
nodejs-github-bot merged commit e800f00 into nodejs:main Apr 16, 2025

nodejs-github-bot commented Apr 16, 2025

Copy link
Copy Markdown
Collaborator

Landed in e800f00

RafaelGSS pushed a commit that referenced this pull request May 1, 2025
src: update std::vector<v8::Local<T>> to use v8::LocalVector<T>
d4a212f 
Refs: #57578
PR-URL: #57646
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
src: update std::vector<v8::Local<T>> to use v8::LocalVector<T>
a7d614a 
Refs: #57578
PR-URL: #57646
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request May 6, 2025
src: update std::vector<v8::Local<T>> to use v8::LocalVector<T>
56d7fec 
Refs: #57578
PR-URL: #57646
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request May 6, 2025
src: update std::vector<v8::Local<T>> to use v8::LocalVector<T>
8b40a96 
Refs: #57578
PR-URL: #57646
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
src: update std::vector<v8::Local<T>> to use v8::LocalVector<T>
8a8b1ab 
Refs: #57578
PR-URL: #57646
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request May 16, 2025
src: update std::vector<v8::Local<T>> to use v8::LocalVector<T>
520fde2 
Refs: #57578
PR-URL: #57646
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request May 17, 2025
src: update std::vector<v8::Local<T>> to use v8::LocalVector<T>
bb262a1 
Refs: #57578
PR-URL: #57646
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request May 18, 2025
src: update std::vector<v8::Local<T>> to use v8::LocalVector<T>
0f8ecb1 
Refs: #57578
PR-URL: #57646
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
github-actions Bot mentioned this pull request May 19, 2025
Merged
aduh95 pushed a commit that referenced this pull request May 19, 2025
src: update std::vector<v8::Local<T>> to use v8::LocalVector<T>
96243a7 
Refs: #57578
PR-URL: #57646
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
ghost mentioned this pull request Jun 8, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
lpinca lpinca approved these changes
joyeecheung joyeecheung approved these changes
legendecas legendecas approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL