tools: enable linter on some fixtures file - #57674
Merged
aduh95 merged 1 commit intoApr 1, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## main #57674 +/- ##
==========================================
- Coverage 90.23% 90.23% -0.01%
==========================================
Files 630 630
Lines 185055 185055
Branches 36220 36218 -2
==========================================
- Hits 166986 166985 -1
- Misses 11039 11040 +1
Partials 7030 7030 see 27 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
aduh95
force-pushed
the
lint-snapshot-files-passing
branch
from
e8baca1 to
a3caa87
Compare
March 31, 2025 18:36
targos
approved these changes
Mar 31, 2025
MoLow
approved these changes
Apr 1, 2025
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/57674 ✔ Done loading data for nodejs/node/pull/57674 ----------------------------------- PR info ------------------------------------ Title tools: enable linter on some fixtures file (#57674) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:lint-snapshot-files-passing -> nodejs:main Labels tools, author ready Commits 1 - tools: enable linter on some fixtures file Committers 1 - Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: https://github.com/nodejs/node/pull/57674 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/57674 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 29 Mar 2025 13:52:29 GMT ✔ Approvals: 2 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/57674#pullrequestreview-2730474037 ✔ - Moshe Atlow (@MoLow): https://github.com/nodejs/node/pull/57674#pullrequestreview-2731759969 ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/14190984322 |
Sorry, something went wrong.
RafaelGSS
pushed a commit
that referenced
this pull request
May 1, 2025
PR-URL: #57674 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
RafaelGSS
pushed a commit
that referenced
this pull request
May 2, 2025
PR-URL: #57674 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
aduh95
added a commit
that referenced
this pull request
May 6, 2025
PR-URL: #57674 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
RafaelGSS
pushed a commit
that referenced
this pull request
May 14, 2025
PR-URL: #57674 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
aduh95
added a commit
that referenced
this pull request
May 17, 2025
PR-URL: #57674 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
aduh95
added a commit
that referenced
this pull request
May 19, 2025
PR-URL: #57674 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Those files used to be linted, until b6738c1 moved them to the fixtures/ dir, which is excluded from lint rules (for good reasons, we have there files that are purposefully testing e.g. edge-case syntax which would be forbidden in the other areas of the codebase). However, with the recent addition of globalIgnores (pending #57673), it's now possible for us to define more precise rules regarding which files are ignored.
(I've chosen to enable it only on subfolder where the files are already passing the linter, I'll open follow-up PRs to enable it in more areas, but the diff is too large for a single PR, see https://github.com/nodejs/node/compare/main...aduh95:node:lint-snapshot-files?expand=1)