FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

lib: fix default AbortController.abort() message by nektro · Pull Request #57735 · nodejs/node · GitHub

/ node Public

lib: fix default AbortController.abort() message - #57735

Closed
nektro wants to merge 1 commit into
nodejs:mainfrom
nektro:patch-5
ConversationCommits (1)ChecksFiles changed
Closed

lib: fix default AbortController.abort() message#57735
nektro wants to merge 1 commit into
nodejs:mainfrom
nektro:patch-5

Conversation

nektro commented Apr 2, 2025

Copy link
Copy Markdown
Contributor

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Apr 2, 2025

codecov Bot commented Apr 2, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.24%. Comparing base (5a2614f) to head (1ab2db6).
⚠️ Report is 3741 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #57735      +/-   ##
==========================================
+ Coverage   90.23%   90.24%   +0.01%     
==========================================
  Files         630      630              
  Lines      185074   184982      -92     
  Branches    36221    36218       -3     
==========================================
- Hits       166994   166946      -48     
+ Misses      11036    10990      -46     
- Partials     7044     7046       +2
Files with missing lines Coverage Δ
lib/internal/abort_controller.js 98.14% <100.00%> (ø)

... and 54 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

RaisinTen approved these changes Apr 3, 2025
View reviewed changes

RaisinTen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM but you need to update the expected error messages in the tests

KhafraDev commented Apr 3, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Where does the spec dictate that the description must be the error message?

For example I'm pretty sure if we implemented URLMismatchError its message wouldn't be "Deprecated.".

KhafraDev added the semver-major PRs that contain breaking changes and should be released in the next major version. label Apr 3, 2025

nektro commented Apr 3, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

taking another look, https://webidl.spec.whatwg.org/#js-creating-throwing-exceptions for DOMException says message is implementation defined.

initially opened this because while investigating other code we noticed Safari, Firefox, Bun use the default description from the spec
Node's message was the default one sans only the period
Chrome's message is signal is aborted without reason
Ladybird's message is Aborted without reason
workerd's message is the default one sans only the period

legendecas commented Apr 7, 2025

Copy link
Copy Markdown
Member

See https://nodejs.org/api/errors.html#errorcode, error message can be changed in any versions of Node.js. I don't think this is necessarily a semver major change.

legendecas mentioned this pull request Apr 7, 2025
Merged

KhafraDev commented Apr 7, 2025

Copy link
Copy Markdown
Member

Mostly being careful because this will break things, mostly tests https://github.com/search?q=%22This+operation+was+aborted%22&type=code

nodejs-github-bot pushed a commit that referenced this pull request Apr 9, 2025
doc: list DOMException as a potential error raised by Node.js
d6b062c 
PR-URL: #57783
Refs: #57735
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
doc: list DOMException as a potential error raised by Node.js
a4e305a 
PR-URL: #57783
Refs: #57735
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
doc: list DOMException as a potential error raised by Node.js
a5ef2e8 
PR-URL: #57783
Refs: #57735
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request May 6, 2025
doc: list DOMException as a potential error raised by Node.js
31d167e 
PR-URL: #57783
Refs: #57735
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
doc: list DOMException as a potential error raised by Node.js
602bf9f 
PR-URL: #57783
Refs: #57735
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request May 16, 2025
doc: list DOMException as a potential error raised by Node.js
0877fb2 
PR-URL: #57783
Refs: #57735
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request May 17, 2025
doc: list DOMException as a potential error raised by Node.js
81720df 
PR-URL: #57783
Refs: #57735
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request May 19, 2025
doc: list DOMException as a potential error raised by Node.js
01cad99 
PR-URL: #57783
Refs: #57735
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

nektro commented Sep 6, 2025

Copy link
Copy Markdown
Contributor Author

bump

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

This pull request has been marked as stale due to 90 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.

github-actions Bot added the stale label Jul 28, 2026
avivkeller closed this Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
RaisinTen RaisinTen approved these changes

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version. stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL