sqlite: add timeout options to DatabaseSync by geeksilva97 · Pull Request #57752 · nodejs/node · GitHub

Closes #57597

This PR adds the timeout option to the DatabaseSync constructor.

Review requested:

@nodejs/sqlite

CI: https://ci.nodejs.org/job/node-test-pull-request/66205/

CI: https://ci.nodejs.org/job/node-test-pull-request/66206/

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.23%. Comparing base (86f86a2) to head (a6f75c9).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_sqlite.cc	83.33%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #57752   +/-   ##
=======================================
  Coverage   90.22%   90.23%           
=======================================
  Files         630      630           
  Lines      185481   185496   +15     
  Branches    36364    36374   +10     
=======================================
+ Hits       167357   167380   +23     
+ Misses      11004    11001    -3     
+ Partials     7120     7115    -5

Files with missing lines	Coverage Δ
src/node_sqlite.h	68.00% <100.00%> (+4.36%)	⬆️
src/node_sqlite.cc	80.49% <83.33%> (+0.01%)	⬆️

... and 23 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

CI: https://ci.nodejs.org/job/node-test-pull-request/66214/

It's official. CI doesn't like me 😅

I need a reapproval because of the commit that fixed linter issues in the markdown.

It's official. CI doesn't like me

To be fair, the CI doesn't like anyone.

Landed in 62426a7

PR-URL: #57752 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

geeksilva97 added the wip Issues and PRs that are still a work in progress. label Apr 5, 2025

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. labels Apr 5, 2025

cjihrig reviewed Apr 5, 2025

View reviewed changes

Comment thread src/node_sqlite.cc Outdated

Comment thread src/node_sqlite.cc Outdated

Comment thread doc/api/sqlite.md Outdated

geeksilva97 force-pushed the sqlite-dbsync-add-timeout branch from 47ee71b to 2913993 Compare April 5, 2025 12:25

cjihrig reviewed Apr 5, 2025

View reviewed changes

Comment thread test/parallel/test-sqlite-timeout.js Outdated

Comment thread test/parallel/test-sqlite-timeout.js Outdated

Comment thread test/fixtures/sqlite/lock-db.js Outdated

cjihrig mentioned this pull request Apr 5, 2025

sqlite: database is locked #57741

Closed

cjihrig reviewed Apr 6, 2025

View reviewed changes

Comment thread test/parallel/test-sqlite-timeout.js Outdated

cjihrig reviewed Apr 6, 2025

View reviewed changes

Comment thread test/parallel/test-sqlite-timeout.js Outdated

geeksilva97 force-pushed the sqlite-dbsync-add-timeout branch 2 times, most recently from e046a85 to 35eaee0 Compare April 11, 2025 19:17

geeksilva97 self-assigned this Apr 11, 2025

geeksilva97 marked this pull request as ready for review April 11, 2025 19:18

geeksilva97 added 3 commits April 11, 2025 16:19

sqlite: add timeout options to DatabaseSync

e3813f6

sqlite: move time out to openconfiguration

bb98586

apply review suggestions

f686dd2

geeksilva97 force-pushed the sqlite-dbsync-add-timeout branch from 35eaee0 to f686dd2 Compare April 11, 2025 19:20

geeksilva97 removed the wip Issues and PRs that are still a work in progress. label Apr 11, 2025

geeksilva97 requested review from cjihrig and jasnell April 11, 2025 19:21

cjihrig approved these changes Apr 11, 2025

View reviewed changes

geeksilva97 added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 11, 2025

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 11, 2025

fix markdown lint issues

a6f75c9

geeksilva97 added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Apr 11, 2025

geeksilva97 requested a review from cjihrig April 12, 2025 15:35

geeksilva97 added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Apr 12, 2025

cjihrig approved these changes Apr 12, 2025

View reviewed changes

cjihrig added commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Apr 12, 2025

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 12, 2025

nodejs-github-bot merged commit 62426a7 into nodejs:main Apr 12, 2025

RafaelGSS pushed a commit that referenced this pull request May 1, 2025

sqlite: add timeout options to DatabaseSync

0835b68

PR-URL: #57752 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

RafaelGSS mentioned this pull request May 1, 2025

2025-05-06, Version 24.0.0 (Current) #57609

Merged

RafaelGSS pushed a commit that referenced this pull request May 2, 2025

sqlite: add timeout options to DatabaseSync

0df87e0

PR-URL: #57752 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

aduh95 pushed a commit that referenced this pull request May 6, 2025

sqlite: add timeout options to DatabaseSync

c6b3c1c

PR-URL: #57752 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

RafaelGSS pushed a commit that referenced this pull request May 14, 2025

sqlite: add timeout options to DatabaseSync

11aa20f

PR-URL: #57752 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

aduh95 pushed a commit that referenced this pull request May 16, 2025

sqlite: add timeout options to DatabaseSync

a51ee78

PR-URL: #57752 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

aduh95 pushed a commit that referenced this pull request May 17, 2025

sqlite: add timeout options to DatabaseSync

f338eb4

PR-URL: #57752 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

aduh95 pushed a commit that referenced this pull request May 18, 2025

sqlite: add timeout options to DatabaseSync

4e80bc9

PR-URL: #57752 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

github-actions Bot mentioned this pull request May 19, 2025

2025-05-21, Version 22.16.0 'Jod' (LTS) #58388

Merged

aduh95 pushed a commit that referenced this pull request May 19, 2025

sqlite: add timeout options to DatabaseSync

c12cd2a

PR-URL: #57752 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

ghost mentioned this pull request Jun 8, 2025

### Notable Changes autofix-ci/action#28

Closed

sqlite: add timeout options to DatabaseSync by geeksilva97 · Pull Request #57752 · nodejs/node · GitHub

Uh oh!

Uh oh!

sqlite: add timeout options to DatabaseSync - #57752

sqlite: add timeout options to DatabaseSync#57752nodejs-github-bot merged 4 commits intonodejs:mainnodejs/node:mainfrom geeksilva97:sqlite-dbsync-add-timeoutgeeksilva97/node:sqlite-dbsync-add-timeoutCopy head branch name to clipboard

Conversation

geeksilva97 commented Apr 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Apr 5, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Apr 11, 2025

Uh oh!

nodejs-github-bot commented Apr 11, 2025

Uh oh!

codecov Bot commented Apr 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nodejs-github-bot commented Apr 12, 2025

Uh oh!

geeksilva97 commented Apr 12, 2025

Uh oh!

cjihrig commented Apr 12, 2025

Uh oh!

nodejs-github-bot commented Apr 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sqlite: add timeout options to DatabaseSync#57752
nodejs-github-bot merged 4 commits into
nodejs:mainfrom
geeksilva97:sqlite-dbsync-add-timeout

geeksilva97 commented Apr 5, 2025 •
edited
Loading

codecov Bot commented Apr 11, 2025 •
edited
Loading