FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build: remove `nocorepack` `vcbuild` flag by aduh95 · Pull Request #57772 · nodejs/node · GitHub

/ node Public

build: remove nocorepack vcbuild flag - #57772

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
aduh95:vcbuild-no-nocorepack
Apr 8, 2025
Merged

build: remove nocorepack vcbuild flag#57772
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
aduh95:vcbuild-no-nocorepack

Conversation

aduh95 commented Apr 6, 2025

Copy link
Copy Markdown
Contributor

It looks like it was forgotten in #57617

aduh95 added dont-land-on-v18.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Apr 6, 2025
nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. windows Issues and PRs related to the Windows platform. labels Apr 6, 2025
aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 6, 2025
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 6, 2025

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

Copy link
Copy Markdown
Collaborator

aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 7, 2025
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 8, 2025
nodejs-github-bot merged commit 86bfdb5 into nodejs:main Apr 8, 2025

Copy link
Copy Markdown
Collaborator

Landed in 86bfdb5

aduh95 deleted the vcbuild-no-nocorepack branch April 8, 2025 09:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. build Issues and PRs related to build files or the CI. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. needs-ci PRs that need a full CI run. windows Issues and PRs related to the Windows platform.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants


Back | FazBrowse Home | New Git URL