Revert "test: add tests for REPL custom evals" - #57793
Merged
nodejs-github-bot merged 1 commit intoApr 8, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This reverts commit 1f7cfb7, which was merged into the main branch despite relevant test failures.
Copy link
Copy Markdown
Contributor
|
Fast-track has been requested by @tniessen. Please 👍 to approve. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Failed to start CI⚠ No approving reviews found ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/14335840440 |
Sorry, something went wrong.
cjihrig
approved these changes
Apr 8, 2025
Copy link
Copy Markdown
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## main #57793 +/- ##
==========================================
- Coverage 90.23% 90.22% -0.02%
==========================================
Files 630 630
Lines 185288 185289 +1
Branches 36344 36342 -2
==========================================
- Hits 167203 167178 -25
- Misses 11006 11009 +3
- Partials 7079 7102 +23
... and 24 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
BridgeAR
approved these changes
Apr 8, 2025
BridgeAR
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
RSLGTM
Sorry, something went wrong.
lpinca
approved these changes
Apr 8, 2025
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
aduh95
approved these changes
Apr 8, 2025
richardlau
approved these changes
Apr 8, 2025
RafaelGSS
pushed a commit
that referenced
this pull request
May 1, 2025
This reverts commit 1f7cfb7, which was merged into the main branch despite relevant test failures. PR-URL: #57793 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
RafaelGSS
pushed a commit
that referenced
this pull request
May 2, 2025
This reverts commit 1f7cfb7, which was merged into the main branch despite relevant test failures. PR-URL: #57793 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
aduh95
pushed a commit
that referenced
this pull request
May 6, 2025
This reverts commit 1f7cfb7, which was merged into the main branch despite relevant test failures. PR-URL: #57793 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
RafaelGSS
pushed a commit
that referenced
this pull request
May 14, 2025
This reverts commit 1f7cfb7, which was merged into the main branch despite relevant test failures. PR-URL: #57793 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
aduh95
pushed a commit
that referenced
this pull request
May 16, 2025
This reverts commit 1f7cfb7, which was merged into the main branch despite relevant test failures. PR-URL: #57793 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
aduh95
pushed a commit
that referenced
this pull request
May 17, 2025
This reverts commit 1f7cfb7, which was merged into the main branch despite relevant test failures. PR-URL: #57793 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
aduh95
pushed a commit
that referenced
this pull request
May 19, 2025
This reverts commit 1f7cfb7, which was merged into the main branch despite relevant test failures. PR-URL: #57793 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
dario-piotrowicz
added a commit
to dario-piotrowicz/node
that referenced
this pull request
Jun 11, 2025
this commit reintroduces the REPL custom eval tests that have been introduced in nodejs#57691 but reverted in nodejs#57793 the tests turned out problematic before because `getReplOutput`, the function used to return the repl output wasn't taking into account that input processing and output emitting are asynchronous operation can resolve with a small delay the new implementation here replaces `getReplOutput` with `getReplRunOutput` that resolves repl inputs by running them and using the repl prompt as an indicator to when the input processing has completed
nodejs-github-bot
pushed a commit
that referenced
this pull request
Jun 15, 2025
this commit reintroduces the REPL custom eval tests that have been introduced in #57691 but reverted in #57793 the tests turned out problematic before because `getReplOutput`, the function used to return the repl output wasn't taking into account that input processing and output emitting are asynchronous operation can resolve with a small delay the new implementation here replaces `getReplOutput` with `getReplRunOutput` that resolves repl inputs by running them and using the repl prompt as an indicator to when the input processing has completed PR-URL: #57850 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos
pushed a commit
that referenced
this pull request
Jun 16, 2025
this commit reintroduces the REPL custom eval tests that have been introduced in #57691 but reverted in #57793 the tests turned out problematic before because `getReplOutput`, the function used to return the repl output wasn't taking into account that input processing and output emitting are asynchronous operation can resolve with a small delay the new implementation here replaces `getReplOutput` with `getReplRunOutput` that resolves repl inputs by running them and using the repl prompt as an indicator to when the input processing has completed PR-URL: #57850 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
aduh95
pushed a commit
that referenced
this pull request
Jul 21, 2025
this commit reintroduces the REPL custom eval tests that have been introduced in #57691 but reverted in #57793 the tests turned out problematic before because `getReplOutput`, the function used to return the repl output wasn't taking into account that input processing and output emitting are asynchronous operation can resolve with a small delay the new implementation here replaces `getReplOutput` with `getReplRunOutput` that resolves repl inputs by running them and using the repl prompt as an indicator to when the input processing has completed PR-URL: #57850 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
aduh95
pushed a commit
that referenced
this pull request
Jul 24, 2025
this commit reintroduces the REPL custom eval tests that have been introduced in #57691 but reverted in #57793 the tests turned out problematic before because `getReplOutput`, the function used to return the repl output wasn't taking into account that input processing and output emitting are asynchronous operation can resolve with a small delay the new implementation here replaces `getReplOutput` with `getReplRunOutput` that resolves repl inputs by running them and using the repl prompt as an indicator to when the input processing has completed PR-URL: #57850 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 1f7cfb7, which, as far as I can tell, was merged into the main branch despite relevant test failures.
The new test also started showing up in reliability reports immediately, see nodejs/reliability#1167.
Refs: #57691 (comment)