FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: clarify Corepack removal in v25+ by trivikr · Pull Request #57813 · nodejs/node · GitHub

/ node Public

doc: clarify Corepack removal in v25+ - #57813

Closed
trivikr wants to merge 4 commits into
mainfrom
trivikr/doc-corepack
ConversationCommits (4)ChecksFiles changed
Closed

doc: clarify Corepack removal in v25+#57813
trivikr wants to merge 4 commits into
mainfrom
trivikr/doc-corepack

Conversation

trivikr commented Apr 10, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Alternative to #57663

This preserves the existing documentation page for corepack which has backlinks from all over the internet.
It can be removed close to April 2028, after corepack is completely removed from all Node.js versions.

Refs:

trivikr added dont-land-on-v18.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Apr 10, 2025
nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 10, 2025
trivikr mentioned this pull request Apr 10, 2025
Merged
trivikr commented Apr 10, 2025
View reviewed changes
Comment thread doc/api/corepack.md Outdated
trivikr requested a review from aduh95 April 10, 2025 04:53
MikeMcC399 reviewed Apr 10, 2025
View reviewed changes
Comment thread doc/api/corepack.md Outdated
ljharb approved these changes Apr 10, 2025
View reviewed changes

ljharb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM with the grammar suggestion

trivikr requested a review from ljharb April 10, 2025 06:19

aduh95 commented Apr 10, 2025

Copy link
Copy Markdown
Contributor

The commit message do not match our guidelines, the first word after the subsystem should be an imperative verb.

trivikr and others added 3 commits April 10, 2025 15:53
doc: clarify Corepack removal in v25+
91336b4
doc: explicitly mention v25+
7fa8646
doc: fix grammar nit
3b95127 
Co-authored-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
trivikr force-pushed the trivikr/doc-corepack branch from f163dc7 to 3b95127 Compare April 10, 2025 15:54
trivikr changed the title doc: corepack no longer distributed in v25+ doc: clarify Corepack removal in v25+ Apr 10, 2025

trivikr commented Apr 10, 2025

Copy link
Copy Markdown
Member Author

@aduh95 I've updated the first commit to use imperative verb after subsystem: doc: clarify Corepack removal in v25+

trivikr commented Apr 10, 2025
View reviewed changes
Comment thread doc/api/corepack.md Outdated

trivikr commented Apr 10, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

Closing this PR, as the existing documentation can be edited better with highlight and call to action just like it's done for other modules for all Node.js versions. That PR is posted in #57825

trivikr closed this Apr 10, 2025
trivikr deleted the trivikr/doc-corepack branch April 10, 2025 17:52

trivikr commented Apr 10, 2025

Copy link
Copy Markdown
Member Author

I'll post a new PR specific to v25.x after #57825 is merged.
There we can change the language to mark corepack as deprecated, just like we did in punycode.

trivikr commented Apr 14, 2025

Copy link
Copy Markdown
Member Author

We're instead trying to enable redirect from corepack latest documentation in nodejs/nodejs.org#7643 (review)

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

MikeMcC399 MikeMcC399 left review comments
lpinca lpinca approved these changes
aduh95 Awaiting requested review from aduh95
ljharb Awaiting requested review from ljharb

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL